Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pref structure for custom background #23323

Closed
sangwoo108 opened this issue Jun 8, 2022 · 1 comment · Fixed by brave/brave-core#13771
Closed

Pref structure for custom background #23323

sangwoo108 opened this issue Jun 8, 2022 · 1 comment · Fixed by brave/brave-core#13771
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@sangwoo108
Copy link

sangwoo108 commented Jun 8, 2022

sub task of #15252 .

This can block other sub tasks for custom background:


According to #15252, there're 4 options for users.

  • custom files
  • brave backgrounds
  • solid colors
  • gradient colors

and there's users can select a specific item from a collection or use random image from a collection.
We should decide pref structures for these.


draft to discuss - done


[
   kNTPBackground: {
      type: ‘brave’ | ‘custom_mage’ | ‘solid_color’ | ‘gradient_olor’
      random: bool  // indicates that we should pick one every time from |selected_type| collection
      selected_value?: string  // url or css value
  }
]
@sangwoo108 sangwoo108 self-assigned this Jun 8, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Jun 8, 2022
@sangwoo108

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants