Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a loading state when switching between Filecoin Mainnet to Testnet #23201

Closed
srirambv opened this issue Jun 2, 2022 · 2 comments · Fixed by brave/brave-core#16859
Closed
Assignees
Labels
bug feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 2, 2022

Description

Add a loading state when switching between Filecoin Mainnet to Testnet

Steps to Reproduce

  1. Import Filecoin from Ledger
  2. Switch to Testnet
  3. Shows Mainnet accounts for a few seconds before loading Testnet accounts

Actual result:

No.loading.state.for.Testnet.mov

Expected result:

Add a loading state so user doesn't pick mainnet accounts for testnet

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @muliswilliam @cypt4

@srirambv srirambv added this to Web3 Jun 2, 2022
@jamesmudgett jamesmudgett added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 7, 2022
@jamesmudgett jamesmudgett added this to the 1.40.x - Beta milestone Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@yrliou
Copy link
Member

yrliou commented Jun 14, 2022

Removing 1.40.x as testnet will be disabled.

@yrliou yrliou removed this from the 1.40.x - Beta milestone Jun 14, 2022
@yrliou yrliou added the front-end-change This task is a front end task and doesn't need any C++ changes label Aug 25, 2022
@josheleonard josheleonard self-assigned this Jan 23, 2023
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Jan 23, 2023
@josheleonard josheleonard moved this from In Progress to In Review in Web3 Jan 25, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 26, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 26, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16859
  • Verified loading state is shown when switching between Mainnet and Testnet account when importing FIlecoin accounts
23201.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants