Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solana support for importing accounts and creating transactions from Ledger #23061

Closed
Douglashdaniel opened this issue May 25, 2022 · 3 comments · Fixed by brave/brave-core#13734
Closed

Add Solana support for importing accounts and creating transactions from Ledger #23061

Douglashdaniel opened this issue May 25, 2022 · 3 comments · Fixed by brave/brave-core#13734
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented May 25, 2022 •
edited by yrliou
Loading

Description

We need to add the ability to import a user's Solana account and make transactions from a Ledger device.

Note: Support of using ledger for dApp transactions are tracked separately at #23842.
@Douglashdaniel Douglashdaniel mentioned this issue May 25, 2022
Merged
24 tasks
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core priority/P2 A bad problem. We might uplift this to the next planned release. labels May 31, 2022
@nvonpentz nvonpentz changed the title Import Solana Account from Ledger Add Solana support for importing accounts and creating transactions from Ledger May 31, 2022
@jamesmudgett jamesmudgett mentioned this issue Jun 7, 2022
Closed
@nvonpentz nvonpentz mentioned this issue Jun 10, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jul 2, 2022
@srirambv srirambv added the QA/Yes label Jul 4, 2022
@yrliou
Copy link
Member

yrliou commented Jul 4, 2022 •
edited by srirambv
Loading

Test plan specified in brave/brave-core#13734 . cc @srirambv

@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2022

The above will require 1.41.93 or higher for 1.41.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2022

Brave 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13734
  • Verified able to sign and approve transactions via Ledger Hardware for imported Solana Accounts
  • Verified able to reject approval transactions via Ledger Hardware for imported Solana Accounts
23061-Linux.mp4
23061-Windows.mp4
23061-macOS.mov

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
@Douglashdaniel Douglashdaniel mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Add hardware support for Solana network brave/brave-core
7 participants
@kjozwiak @yrliou @nvonpentz @srirambv @Douglashdaniel @brave-builds and others