Push notifications broken in brave-core #2301

capouch · 2018-11-29T23:44:44Z

Description

HTML5 push notifications, which were previously working, no longer function in the brave-core milieu.

Test Plan

Steps to Reproduce

Go to this site: https://serviceworke.rs/push-payload_demo.html
Choose "Allow" when presented with push notification popup
Enter message and request notification.

Actual result:

Popup posts, and site is registered with browser as "allowed" to send notifications. But nothing happens when the "Request sending . . . " button is pushed.

Expected result:

Browser should respond with a notification popup

Reproduces how often:

Always.

Brave version (brave://version info)

0.57.8

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds?
Yes.

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
No.
Is the issue reproducible on the latest version of Chrome?
Works just fine in latest version of Chrome Beta.

Additional Information

Subscription object is never sent to backend for processing, as verified with two sites I control which both are able to successfully send push notifications to instances of Chrome.

rebron · 2018-12-04T20:05:05Z

@srirambv can you investigate maybe with a different HTML 5 push notification test suite? Need more info on this one.

Brave-Matt · 2018-12-13T23:55:20Z

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/a5xy25/cant_enable_facebook_notifications_in_brave/

Brave-Matt · 2018-12-13T23:55:39Z

May also be related to #2362

felschr · 2019-03-18T19:58:28Z

Looks like the issue I mentioned in the following comment over here is related to this:
#2143 (comment)
The promise from pushManager.subscribe is stuck in status pending.

Indjov · 2019-03-20T22:40:07Z

Any news ? When we see the update witch will fix that notification problem?

stefanmaric · 2019-03-29T14:21:47Z

I'm also seeing that after allowing notifications, and maybe a refresh or something, the site settings says notifications are enabled but registration.pushManager.getSubscription() resolves null.

ACheshirov · 2019-04-09T18:12:08Z

Ya, this bug is very annoying. I hope they will fix it soon. I was struggling to enable Facebook notifications and now I understand why it was unsuccessful.

snowbound · 2019-04-09T20:16:15Z

The main reason why I went back to Chrome after trying Brave for a month back in Nov/Dec last year and now MS has entered the chromium fray

Indjov · 2019-04-10T14:50:51Z

@rebron , any info about that bug?

ishinome · 2019-04-10T20:02:03Z

@rebron I would also like to confirm that these notifications are faulty. For example site: d2jsp.org wont register push notifications with brave, but does it on chrome.

WorldLanguages · 2019-06-24T20:24:06Z

+1
Please work on this Brave team. I want to receive web push notifications from Twitter, Youtube, etc.

nexxai · 2019-07-28T01:19:13Z

@rebron Any update on this? I love the idea of this browser but broken Facebook and Twitter notifications are kind of a deal breaker.

snowbound · 2019-07-28T04:00:19Z

Yup with me its YouTube notifications have to work. The reason why I was one of the people who reported this issue back in Dec 2018. Using Firefox right now on Win10.

rebron · 2019-07-31T15:35:32Z

@nexxai Dependent on #4431 Can't give you a timeline on the fix but we have this on our board to address.

nexxai · 2019-07-31T15:39:32Z

@rebron Can I humbly request that this have a due date set prior to Google's Declarative Web Request/Manifest v3 enabling (I believe this is expected in October)? I imagine that there will be many people looking to switch around that time (when ad blockers like uBlock Origin will no longer work, at least in their current form), and so the easier the transition for them, the more likely they'll be to choose Brave over something like Firefox or Opera.

WorldLanguages · 2019-10-04T19:23:19Z

Finally

jumde · 2019-10-04T20:44:59Z

Fix for this issue enables Push notifications in Brave, but push notifications on some sites including Youtube, Twitter might not work because of an upstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1011244 - we are working with the chromium team to fix this. We are using issue #2362 to track the fix. Stay tuned!

jumde · 2019-10-04T20:45:15Z

Is this going to be fixed in Brave for Android as well?

cc: @anthonypkeane @SergeyZhukovsky

LaurenWags · 2019-11-20T18:53:43Z

Verified passed with

Brave	1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

Verified test plan from Issue 2301: Enable push messaging brave-core#3390 using second site listed in the PR (first site listed was taken down).
Verified on clean and upgrade profiles.

Encountered Push notifications broken in brave-core #2301 (comment) / Tracking issue for crbug 1011244 (DCHECK failed: !connected. NotificationService::GetNotificationsCallback) #7031. Intermittent push notification failures observed during testing with site from PR, however per discussion with @jumde this could be due to rate limiting to avoid bots.

Verification passed on

Brave	1.1.7 Chromium: 78.0.3904.108 (Official Build) beta (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from Issue 2301: Enable push messaging brave-core#3390 for both new and upgraded profiles

Verified that the push notification doesn't work for https://serviceworke.rs/push-payload_demo.html after push messaging is disabled
Could not test https://gauntface.github.io/simple-push-demo/ when push messaging is disabled as the service was down

Verification passed on

Brave	1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

Verified test plan from Issue 2301: Enable push messaging brave-core#3390 for both new and upgraded profiles

snowbound · 2019-11-21T03:00:13Z

Sorry but in Windows10 1909 I am still not seeing notifications in the browser nor in Windows Action Center from YouTube when a subscribed channel goes live. I have notications enabled for Brave in Windows10 just like I do for Chrome and Firefox which both work wrt Windows 10 Action Center. I am currently using Version 1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit). <https://brave.com/latest/>

…

On Wed, Nov 20, 2019 at 12:53 PM Lauren ***@***.***> wrote: Verified passed with Brave 1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit) Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{ #859 <#859>} OS macOS Version 10.13.6 (Build 17G5019) - Verified test plan from brave/brave-core#3390 <brave/brave-core#3390> using second site listed in the PR (first site listed was taken down). - Verified on clean and upgrade profiles. [image: Screen Shot 2019-11-20 at 1 43 20 PM] <https://user-images.githubusercontent.com/28145373/69268312-dedc3a80-0b9c-11ea-876f-9890d3a84aea.png> [image: Screen Shot 2019-11-20 at 1 43 27 PM] <https://user-images.githubusercontent.com/28145373/69268322-e6034880-0b9c-11ea-9e20-8d30885085cf.png> [image: PR3390-clean profile] <https://user-images.githubusercontent.com/28145373/69268442-24006c80-0b9d-11ea-90d1-7ad9f130adde.png> - Encountered #2301 (comment) <#2301 (comment)> / #7031 <#7031>. Intermittent push notification failures observed during testing with site from PR, however per discussion with @jumde <https://github.com/jumde> this could be due to rate limiting to avoid bots. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2301?email_source=notifications&email_token=AAERRMYUPEXXSOYJEFHBZ3LQUWBTRA5CNFSM4GHK6APKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEETZJJQ#issuecomment-556242086>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAERRM42SDSZMDPNKHMOTFLQUWBTRANCNFSM4GHK6APA> .

GeetaSarvadnya · 2019-11-21T11:54:02Z

@snowbound #2301 (comment)

capouch · 2019-11-28T05:37:38Z

OMG it looks like we're broken again in 1.1.11!! I'll revert ASAP and re-test, but just tested with several sites that worked OK last week. None work now.

Update: There is a problem, but it turns out to not be in the push notification functionality per se. I am now on a different machine, and I noticed that the "Use Google Services for Push Notifications" was turned off somehow. I turned it on, and a "RELAUNCH" button comes up next to the setting. I hit it, machine relaunched, but notifications still didn't work. Then I sent the message above. Slackware 14.2-current (recent install)

After banging my head on the wall and reverting all the way back to 1.1.1, which I knew worked OK, it still didn't work!! Went to settings, and I see the "Use Google" is still turned off!! I turned it on, relaunched, looked at settings it it still wan't on. So I turned it on, manually exited via the menu, and now all is well. . . . .

neerajsrivastava · 2019-12-23T10:52:34Z

I noticed that the "Use Google Services for Push Notifications" is turned off by default on Brave (Version 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)).

Is it mandatory to enable it for Push Notifications or there is any other way to send Push Notifications without enabling this setting?
Push Notifications does not work if I do not enable this settings and throws below error .
We can check it on URL https://gauntface.github.io/simple-push-demo/

"Ooops a Problem Occurred
AbortError: Registration failed - push service not available"

bsclifton · 2019-12-30T18:40:13Z

@neerajsrivastava it's required to enable that setting (as far as I know), as there is a service call being made to GCM / FCM ☹️

totomaze · 2020-01-02T03:05:36Z

Where is the option to enable google services ?
Brave is up to date
Version 0.70.123 Chromium: 78.0.3904.97 (Official Build) (64-bit)

I can't see any option in chrome://settings/privacy

Thanks

snowbound · 2020-01-02T03:56:51Z

"Use Google Services for Push Messaging" in Windows Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)

nexxai · 2020-01-02T04:14:23Z

When I try to enable "Use Google Services for Push Messaging" in the Advanced settings section, it prompts me to relaunch, but as soon as I do, the option is disabled again.

After relaunching:

Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
MacOS 10.15.2

bsclifton · 2020-01-02T04:28:10Z

@totomaze you're several versions behind. Can you please update? (current version is 1.1.23 as @snowbound called out above)

@nexxai I believe we fixed that bug, but the fix may not be live yet (cc: @jumde). Instead of clicking the relaunch helper button, can you try just closing Brave manually?

totomaze · 2020-01-02T04:39:42Z

I guess the up to date status is not working.

I downloaded the latest version from the website and I can see the option now . Thanks

I ll start promoting the brave browser in my app when a solution enabled by default will be present :)

nexxai · 2020-01-02T05:01:49Z

@nexxai I believe we fixed that bug, but the fix may not be live yet (cc: @jumde). Instead of clicking the relaunch helper button, can you try just closing Brave manually?

This seems to have done the trick. After just closing the browser with CMD-Q and re-opening, the toggle stayed enabled. Thanks!

jumde · 2020-01-02T16:54:11Z

@nexxai @bsclifton - Yes this issue is fixed, but is not yet part of the stable release - brave/brave-core#4042

jshan17 · 2020-03-20T00:03:43Z

Hello I have Google push notifcations enabled AND I have Notifcations settings set to allow sites to ask. Only popular sites like Facebook and Trading View are successfully asking for notifications when I visit them, then their push notifications actually send. But news sites like Bitcoinist.com and Youtube are not asking. Does anyone know how to enable website push notifications? I’ve already gone to settings and selected, Allow Sites to ask for permission, but my crypto news sites won’t ask for permission to send notifications. I'm using Windows 10 -Brave is up to date: Version 1.5.113 Chromium: 80.0.3987.149 (Official Build) (64-bit) - just updated today. But I cannot receive notifications from sites like Youtube, Twitter, or Crypto news sites. I've seen many different threads on this topic but none have solved my issue. I've also been able to receive notifications from testing sites listed, but still no improvement. Help??

SebasG22 · 2021-06-19T13:52:46Z

When I try to enable "Use Google Services for Push Messaging" in the Advanced settings section, it prompts me to relaunch, but as soon as I do, the option is disabled again.

After relaunching:

Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
MacOS 10.15.2

Nice solution. This works for me. 🚀 🥳

bbondy added this to the 1.x Backlog milestone Dec 2, 2018

rebron added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Dec 4, 2018

rebron added needs-investigation A bug not 100% confirmed/fixed and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 5, 2018

rebron removed the needs-investigation A bug not 100% confirmed/fixed label Jan 15, 2019

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 15, 2019

rebron modified the milestone: 1.x Backlog Feb 7, 2019

kjozwiak added the feature/notifications label Jul 30, 2019

szaimen mentioned this issue Oct 10, 2019

Please fix push-notifications on Android #6403

Closed

bsclifton mentioned this issue Oct 22, 2019

Outlook notifications unavailable #6559

Closed

LesterCovax mentioned this issue Oct 28, 2019

"Join" extension won't function in Brave #2408

Closed

LaurenWags added the QA Pass-macOS label Nov 20, 2019

GeetaSarvadnya added the QA Pass-Win64 label Nov 21, 2019

btlechowski added the QA Pass-Linux label Nov 21, 2019

LaurenWags added the release-notes/include label Dec 9, 2019

LaurenWags mentioned this issue Dec 9, 2019

Release notes for 1.1.x (Release Channel) #7288

Closed

pushy mentioned this issue Oct 13, 2020

Failed to subscribe pushy/pushy-sdk-web#1

Closed

TheodoorP mentioned this issue Jan 7, 2021

Unable to enable push notifications everyday-as/pivity-issues#980

Closed

spiffytech mentioned this issue Jan 28, 2021

web-push-notifications-tutorial/ fgerschau/comments#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Push notifications broken in brave-core #2301

Push notifications broken in brave-core #2301

capouch commented Nov 29, 2018 •

edited by jumde

Loading

rebron commented Dec 4, 2018

Brave-Matt commented Dec 13, 2018

Brave-Matt commented Dec 13, 2018

felschr commented Mar 18, 2019

Indjov commented Mar 20, 2019

stefanmaric commented Mar 29, 2019

ACheshirov commented Apr 9, 2019

snowbound commented Apr 9, 2019

Indjov commented Apr 10, 2019

ishinome commented Apr 10, 2019

WorldLanguages commented Jun 24, 2019

nexxai commented Jul 28, 2019

snowbound commented Jul 28, 2019

rebron commented Jul 31, 2019

nexxai commented Jul 31, 2019

WorldLanguages commented Oct 4, 2019

jumde commented Oct 4, 2019

jumde commented Oct 4, 2019

LaurenWags commented Nov 20, 2019 •

edited by btlechowski

Loading

snowbound commented Nov 21, 2019 via email •

edited

Loading

GeetaSarvadnya commented Nov 21, 2019

capouch commented Nov 28, 2019 •

edited

Loading

neerajsrivastava commented Dec 23, 2019

bsclifton commented Dec 30, 2019

totomaze commented Jan 2, 2020

snowbound commented Jan 2, 2020

nexxai commented Jan 2, 2020 •

edited

Loading

bsclifton commented Jan 2, 2020 •

edited

Loading

totomaze commented Jan 2, 2020 •

edited

Loading

nexxai commented Jan 2, 2020

jumde commented Jan 2, 2020

jshan17 commented Mar 20, 2020

SebasG22 commented Jun 19, 2021 •

edited

Loading

Push notifications broken in brave-core #2301

Push notifications broken in brave-core #2301

Comments

capouch commented Nov 29, 2018 • edited by jumde Loading

Description

Test Plan

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

Website problems only:

Additional Information

rebron commented Dec 4, 2018

Brave-Matt commented Dec 13, 2018

Brave-Matt commented Dec 13, 2018

felschr commented Mar 18, 2019

Indjov commented Mar 20, 2019

stefanmaric commented Mar 29, 2019

ACheshirov commented Apr 9, 2019

snowbound commented Apr 9, 2019

Indjov commented Apr 10, 2019

ishinome commented Apr 10, 2019

WorldLanguages commented Jun 24, 2019

nexxai commented Jul 28, 2019

snowbound commented Jul 28, 2019

rebron commented Jul 31, 2019

nexxai commented Jul 31, 2019

WorldLanguages commented Oct 4, 2019

jumde commented Oct 4, 2019

jumde commented Oct 4, 2019

LaurenWags commented Nov 20, 2019 • edited by btlechowski Loading

snowbound commented Nov 21, 2019 via email • edited Loading

GeetaSarvadnya commented Nov 21, 2019

capouch commented Nov 28, 2019 • edited Loading

neerajsrivastava commented Dec 23, 2019

bsclifton commented Dec 30, 2019

totomaze commented Jan 2, 2020

snowbound commented Jan 2, 2020

nexxai commented Jan 2, 2020 • edited Loading

bsclifton commented Jan 2, 2020 • edited Loading

totomaze commented Jan 2, 2020 • edited Loading

nexxai commented Jan 2, 2020

jumde commented Jan 2, 2020

jshan17 commented Mar 20, 2020

SebasG22 commented Jun 19, 2021 • edited Loading

capouch commented Nov 29, 2018 •

edited by jumde

Loading

LaurenWags commented Nov 20, 2019 •

edited by btlechowski

Loading

snowbound commented Nov 21, 2019 via email •

edited

Loading

capouch commented Nov 28, 2019 •

edited

Loading

nexxai commented Jan 2, 2020 •

edited

Loading

bsclifton commented Jan 2, 2020 •

edited

Loading

totomaze commented Jan 2, 2020 •

edited

Loading

SebasG22 commented Jun 19, 2021 •

edited

Loading