Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of hover indication and clickable area for New Tab button #22902

Closed
bradleyrichter opened this issue May 17, 2022 · 1 comment · Fixed by brave/brave-core#13583

Comments

@bradleyrichter
Copy link

bradleyrichter commented May 17, 2022

Our current New (+) button is noticeably smaller than chrome which may be causing some usability issues.

The style will not be negatively effected if we make the clickable area larger.

Current compared to chrome (shown as overlay circle)

image

New size to improve usability of click region:

image

Assuming the squircle is based on a center point, enlarging it from 20px to 28px should work.

@stephendonner
Copy link

stephendonner commented Jun 10, 2022

Verified PASSED using

Brave 1.41.55 Chromium: 102.0.5005.115 (Official Build) nightly (x86_64)
Revision 174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS macOS Version 12.5 (Build 21G5037d)

Visually inspected and compared default and hover states between 1.41.55 and 1.39.120.

Confirmed larger hover region.

Dark theme/mode

1.41.55 1.39.120
default Screen Shot 2022-06-10 at 3 45 12 PM Screen Shot 2022-06-10 at 3 45 12 PM
hover Screen Shot 2022-06-10 at 3 45 06 PM Screen Shot 2022-06-10 at 3 46 34 PM

Light theme/mode

1.41.55 1.39.120
default Screen Shot 2022-06-10 at 3 44 24 PM Screen Shot 2022-06-10 at 3 46 01 PM
hover Screen Shot 2022-06-10 at 3 44 14 PM Screen Shot 2022-06-10 at 3 45 56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants