Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up Privacy Policy link in Contact technical support form #22713

Closed
stephendonner opened this issue May 6, 2022 · 4 comments
Closed

Hook up Privacy Policy link in Contact technical support form #22713

stephendonner opened this issue May 6, 2022 · 4 comments

Comments

@stephendonner
Copy link

stephendonner commented May 6, 2022

Description

Hook up Privacy Policy link in Contact technical support form

Steps to Reproduce

  1. install 1.39.92
  2. launch Brave
  3. set up a working VPN connection (use https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB)
  4. click on the VPN icon
  5. click on the gear/Settings icon
  6. click Contact technical support
  7. in the resulting technical-support request dialog, click on the Privacy Policy link
step 4 step 5 step 6/7
Screen Shot 2022-05-05 at 5 26 19 PM Screen Shot 2022-05-05 at 5 26 24 PM Screen Shot 2022-05-05 at 5 26 39 PM

Actual result:

Nothing happens

Expected result:

The Privacy Policy link should work and open the appropriate link (unsure destination URL)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.92 Chromium: 101.0.4951.54 (Official Build) beta (x86_64)
Revision 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS macOS Version 12.4 (Build 21F5071b)

cc @nullhook @simonhong @bsclifton @rebron @brave/qa-team

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 19, 2022
@stephendonner stephendonner changed the title Hook up Privacy Policy link in Contact technical support form Hook up Privacy Policy link in Contact technical support form May 20, 2022
@GeetaSarvadnya
Copy link

++reproduced on windows 10 x64

@stephendonner
Copy link
Author

This looks like it works fine in

Brave 1.41.19 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

@spylogsster mind linking to the commit/issue which fixed this, too? Thanks!

Screen Shot 2022-05-27 at 3 24 11 AM

@spylogsster
Copy link

spylogsster commented Jun 21, 2022

@stephendonner I think it was fixed in brave/brave-core#13348

@spylogsster spylogsster added this to the 1.41.x - Beta milestone Jun 21, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Working as expected. Clicking on Privacy Policy Link, redirected to Brave Browser Privacy Policy page

Ex1 Ex2
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants