Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFs are still opened in-browser even though "Download PDF files instead of automatically opening them in Brave" is on #2267

Closed
alabamavtec opened this issue Nov 28, 2018 · 3 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@alabamavtec
Copy link

alabamavtec commented Nov 28, 2018

SEE ISSUE 1531:

#1531

Description

When I attempt to download any .pdf file, the file is opened by the built in brave PDF viewer even though "Download PDF files instead of automatically opening them in Brave" is turned on (Settings > Advanced Settings > Content Settings > PDF documents).

Steps to Reproduce

  1. Turn "Download PDF files instead of automatically opening them in Brave" on;
  2. Close Browser
  3. Reopen Browser
  4. Open any link to a pdf
    ex: http://www.africau.edu/images/default/sample.pdf

Actual result:

Opens PDF in-browser

Expected result:

Opens file manager to ask for download location

Reproduces how often:

Occurs every time

Brave version (brave://version info)

Brave | 0.56.15 Chromium: 70.0.3538.110 (Official Build) (64-bit)
-- | --
Revision | ca97ba107095b2a88cf04f9135463301e685cbb0-refs/branch-heads/3538@{#1094}
OS | Linux
JavaScript | V8 7.0.276.40
Flash | (Disabled)
User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36
Command Line | /usr/bin/brave-browser --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor,AutofillSaveCardSignInAfterLocalSave,kAutofillServerCommunication --flag-switches-begin --flag-switches-end
Executable Path | /opt/brave.com/brave/brave-browser
Profile Path | /home/alabamavtec/.config/BraveSoftware/Brave-Browser/Default

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Have not attempted on dev/beta

Website problems only:

  • Can not disable brave shields for PDF viewer

  • On Chromium (Version 70.0.3538.110 (Official Build) Built on Ubuntu, running on Ubuntu 18.10 (64-bit)) with the same settings on, the file manager is opened like it is supposed to and it asks for a download location

@Techguyprivate
Copy link

Duplicate issue. Have you searched for any similar issues before creating ? Anyway , thank you for confirming that the problem exists in 0.56.15 on Ubuntu 18.10 ( 64bit ) . I can confirm that the problem exists on Brave beta version 0. 57.8 & stable 0.56.15 on Ubuntu & windows too.

#1531

@alabamavtec
Copy link
Author

Duplicate issue. Have you searched for any similar issues before creating ? Anyway , thank you for confirming that the problem exists in 0.56.15 on Ubuntu 18.10 ( 64bit ) . I can confirm that the problem exists on Brave beta version 0. 57.8 & stable 0.56.15 on Ubuntu & windows too.

#1531

Ah, I am sorry to duplicate issue. Will link yours issue in comment and update version info.

@Techguyprivate
Copy link

Ah, I am sorry to duplicate issue. Will link yours issue in comment and update version info.

Oh , My Dear friend. You don't need to say sorry at all . In fact , I am sorry if I or my reply sounded as
bossy or rude. I will fight for your right to post duplicate issues .Kidding. That will be liitle hard for awsome devs working on the awesome project. Free to post any . Hope I didn't discourage you in anyway.

@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
@tildelowengrimm tildelowengrimm added the closed/duplicate Issue has already been reported label Dec 3, 2018
@tildelowengrimm tildelowengrimm modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Dec 3, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

4 participants