You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I do an import for Brave Payments (discovered by @LaurenWags with brave/brave-core#736), values like minimum visit time, # visits, allow unverified contributions, etc are imported and put into the publisher_state file
Each web_ui page is keeping its store in local storage... but in this case, the code is never initialized with the values from the RewardsService (in C++)
Test plan / Steps to Reproduce
Fresh profile
Visit brave://rewards and enable rewards
Quit Brave
Open the Default/publisher_state file in your session directory, using your favorite editor
Edit the JSON and change min_pubslisher_duration to 60
Re-launch Brave
Open Auto-Contribute settings (the gear icon)
Actual result:
UI shows 8 seconds, not 1 minute
Expected result:
UI should respect value from Default/publisher_state (60 seconds / 1 minute)
Verified the following settings were imported from muon appropriately: Minimum page time before logging a visit, Minimum visits for publisher relevancy, Allow contribution to non-verified sites, Allow contribution to videos
Description
Likely the same root cause as #2260
If I do an import for Brave Payments (discovered by @LaurenWags with brave/brave-core#736), values like minimum visit time, # visits, allow unverified contributions, etc are imported and put into the
publisher_state
fileWhen you visit brave://rewards, it shows the default values that are coming from here:
https://github.com/brave/brave-core/blob/a07948dd2cb553cb7650d879b81f05f6f5bdcb35/components/brave_rewards/resources/ui/storage.ts#L10-L49
Each web_ui page is keeping its store in local storage... but in this case, the code is never initialized with the values from the RewardsService (in C++)
Test plan / Steps to Reproduce
Default/publisher_state
file in your session directory, using your favorite editormin_pubslisher_duration
to60
Auto-Contribute settings
(the gear icon)Actual result:
UI shows 8 seconds, not 1 minute
Expected result:
UI should respect value from
Default/publisher_state
(60 seconds / 1 minute)Reproduces how often:
100%
Brave version (brave://version info)
master brave/brave-core@a07948d
Reproducible on current release:
Yes
Additional Information
I started to do a fix last nite and verified that this does indeed set the values:
brave/brave-core@16e2ee6
However, it doesn't seem to set all of the values properly. I might have a misspelling for the preference names
The text was updated successfully, but these errors were encountered: