Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Etherscan passthrough code #22602

Closed
nvonpentz opened this issue Apr 28, 2022 · 0 comments · Fixed by brave/brave-core#13220
Closed

Remove unused Etherscan passthrough code #22602

nvonpentz opened this issue Apr 28, 2022 · 0 comments · Fixed by brave/brave-core#13220
Assignees
@nvonpentz
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.40.x - Release

Comments

@nvonpentz
Copy link
Member

There is some Etherscan passthrough code leftover from #20469 such as this parsing logic. Let's remove it.
@nvonpentz nvonpentz added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 28, 2022
@nvonpentz nvonpentz self-assigned this Apr 28, 2022
@nvonpentz nvonpentz mentioned this issue Apr 29, 2022
Merged
25 tasks
@nvonpentz nvonpentz added this to Web3 May 9, 2022
@nvonpentz nvonpentz moved this to Done in Web3 May 9, 2022
@nvonpentz nvonpentz added this to the 1.40.x - Nightly milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Remove unused Etherscan passthrough code brave/brave-core
1 participant
@nvonpentz