Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Torrent Buttons are misplaced #22596

Closed
lkyuchukov opened this issue Apr 28, 2022 · 2 comments · Fixed by brave/brave-core#13214
Closed

Download Torrent Buttons are misplaced #22596

lkyuchukov opened this issue Apr 28, 2022 · 2 comments · Fixed by brave/brave-core#13214
Assignees
Labels
bug feature/webtorrent Label for webtorrent related issues OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes regression release-notes/include

Comments

@lkyuchukov
Copy link

Description

Start Torrent/Save Torrent File/Copy Magnet Link buttons seem to be misplaced.

Steps to Reproduce

  1. Launch Brave and open https://webtorrent.io/torrents/big-buck-bunny.torrent
  2. The Start Torrent/Save Torrent File seem to be awkwardly placed one above the other
  3. The same applies for magnet links

Actual result:

Screenshot 2022-04-28 at 12 56 54

Expected result:

Buttons are placed one next to another with sufficient margin between them and the title of the torrent.

Reproduces how often:

Everytime

Brave version (brave://version info)

Brave | 1.37.116 Chromium: 100.0.4896.127 (Official Build) (arm64)
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | macOS Version 12.0.1 (Build 21A559)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No such functionality in Chrome AFAIK

Miscellaneous Information:

@rebron rebron added the feature/webtorrent Label for webtorrent related issues label Apr 28, 2022
@lkyuchukov
Copy link
Author

I'd like to pick this up

@rebron rebron added bug regression QA/Yes priority/P4 Planned work. We expect to get to it "soon". labels May 19, 2022
@fallaciousreasoning fallaciousreasoning added the polish Nice to have — usually related to front-end/visual tasks label Jul 21, 2022
@rebron rebron added this to the 1.44.x - Nightly milestone Aug 3, 2022
@stephendonner
Copy link

stephendonner commented Aug 5, 2022

Verified PASSED using

Brave 1.44.21 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Confirmed:

  • vastly improved layout (thanks @fallaciousreasoning !)
  • Stop Torrent button stops and resets the file transfer (for both .torrent and magnet:? links)
  • Start Torrent begins file transfer
  • Copy Magnet Link populates the clipboard with the URI
  • Save .torrent File prompts to save big-buck-bunny.torrent
  • no Dark mode support (will investigate/file)
.torrent file magnet:? link
Screen Shot 2022-08-05 at 3 19 59 PM Screen Shot 2022-08-05 at 3 21 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/webtorrent Label for webtorrent related issues OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes regression release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants