Migrate away from Rewards Extension to WebUI: Make background page of Reward Extension non-persistent

[atuchin-m]

Currently if rewards is enabled Reward Extension lives forever and consumes user memory.
The extension process should be launched only if the panel opened.

The entry point in the code: brave_rewards_panel_background.js

slack discussion: https://bravesoftware.slack.com/archives/CNH9Q6REV/p1650469219904509

[LaurenWags]

Marking as QA/Blocked until #24546 is resolved via Griffin. Worst case scenario we can test via flag manipulation on brave://flags.

[LaurenWags]

Verified with

Brave | 1.43.73 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | macOS Version 12.5 (Build 21G72)

WebUI panel disabled - PASSED

Verified the following items from brave/brave-core#13719 (comment) for when the feature flag, #brave-rewards-webui-panel, is disabled. Note, this must be done manually as it is enabled via griffin for Nightly and Beta currently.

• All strings on the Rewards panel are displayed properly.

Uphold/Gemini region onboarding:

1	2	3	4	5	6	7	8	9

bitFlyer region onboarding:

1	2	3	4	5	6	7	8

Various panel views:

Notification	Summary	Creator	Custodian drop-down

Ad grant panel modals:

Example	Example	Example

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5 (Build 21G72)

• Publisher info is displayed properly in the panel for a variety of publishers.
  • Used a mix of verified and not verified creators below to display the various creator types

Site	YouTube	Vimeo	Reddit	Twitch	Twitter	GitHub

• Confirmed after enabling Rewards from the NTP, the panel is opened with the Rewards tour displayed.

Example	Example

• Adaptive captcha items:
  • Confirmed received adaptive captcha at appropriate time when scheduled
  • Confirmed adaptive captcha is displayed correctly when the user clicks on the "Solve" button for adaptive captcha
  • Confirmed able to solve adaptive captcha successfully
  • Confirmed able to select "Later" and the prompt is displayed later
  • Confirmed able to fail captcha several times and then pass successfully
  • Confirmed if Rewards icon is hidden, when clicking on "Solve", the Rewards icon shows, the panel opens, and the adaptive captcha is displayed
  • Confirmed if I click "Solve" on the prompt, the adaptive captcha is shown on the panel. If I then close the panel, and reopen it - the adaptive captcha is still there, waiting to be solved.
  • Confirmed if the max attempts at the captcha are met without success, there is UI instructing the user to contact support
  • Confirmed the "Contact Support" button opens Brave Help Center in a new tab

Example	Example	Example	Example	Example

• Ad grant claims from NTP and brave://rewards
  • Confirmed ad grant captchas can be opened from the NTP
  • Confirmed ad grant captchas can be successfully claimed
  • Confirmed ad grant captchas can be opened from brave://rewards
  • Confirmed ad grant captchas can be successfully claimed

Claim Ad grant from NTP	Claim Ad grant from NTP	Claim Ad grant from brave://rewards	Claim Ad grant from brave://rewards

• Confirmed rewards icon "checkmark" state and publisher info is correct for Greaselion publishers:

Brave Verified creators:

GitHub	Twitter	Reddit	YouTube	Vimeo	Twitch

Non Verified creators:

GitHub	Twitter	Reddit	YouTube	Vimeo	Twitch

• Confirmed the Rewards panel can be opened from the settings page when the user has not enabled Rewards.

Example	Example

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5 (Build 21G72)

WebUI panel enabled - PASSED, follow up issue logged

Verified the following items from brave/brave-core#13719 (comment) for when the feature flag, #brave-rewards-webui-panel, is enabled. Note, must restart on Nightly/Beta so that the BraveRewardsWebUiPanelStudy:Enabled is shown on brave://version as this is the Griffin study which enables this flag. Alternatively, you could manually enable the flag which requires a browser restart.

• All strings on the Rewards panel are displayed properly.

Uphold/Gemini region onboarding:

1	2	3	4	5	6	7	8	9

bitFlyer region onboarding:

1	2	3	4	5	6	7	8

Various panel views:

Notification	Summary	Creator	Custodian drop-down

Ad Grant panel modals:

Example	Example	Example

• Publisher info is displayed properly in the panel for a variety of publishers.
  • Used a mix of verified and not verified creators below to display the various creator types

Site	YouTube	Vimeo	Reddit	Twitch	Twitter	GitHub

• After enabling Rewards from the NTP, the panel is opened with the Rewards tour displayed.

Example	Example

• Adaptive captcha items:
  • Confirmed received adaptive captcha at appropriate time when scheduled
  • Confirmed adaptive captcha is displayed correctly when the user clicks on the "Solve" button for adaptive captcha
  • Confirmed able to solve adaptive captcha successfully
  • Confirmed able to select "Later" and the prompt is displayed later
  • Confirmed able to fail captcha several times and then pass successfully
  • Confirmed if Rewards icon is hidden, when clicking on "Solve", the Rewards icon shows, the panel opens, and the adaptive captcha is displayed
  • Confirmed if I click "Solve" on the prompt, the adaptive captcha is shown on the panel. If I then close the panel, and reopen it - the adaptive captcha is still there, waiting to be solved.
  • Confirmed if the max attempts at the captcha are met without success, there is UI instructing the user to contact support
  • FAILED - the "Contact Support" button does not open Brave Help Center in a new tab, logged follow up issue "Contact Support" from adaptive captcha doesn't work with WebUI rewards panel #24846

Example	Example	Example	Example

• Ad grant claims from NTP and brave://rewards
  • Confirmed ad grant captchas can be opened from the NTP
  • Confirmed ad grant captchas can be successfully claimed
  • Confirmed ad grant captchas can be opened from brave://rewards
  • Confirmed ad grant captchas can be successfully claimed

Claim Ad grant from NTP	Claim Ad grant from NTP	Claim Ad grant from brave://rewards	Claim Ad grant from brave://rewards

• Button "checkmark" state and publisher info is correct for Greaselion publishers.

Brave Verified creators:

GitHub	Twitter	Reddit	YouTube	Vimeo	Twitch

Non Verified creators:

GitHub	Twitter	Reddit	YouTube	Vimeo	Twitch

• Confirmed the Rewards panel can be opened from the settings page when the user has not enabled Rewards.

Example	Example

• For a variety of publishers, the Rewards icon shows the correct "checkmark" badge.
  • See above for GL publisher checks for both verified and non-verified creators
  • See below for regular site checks for both verified and non-verified creators

Brave Verified sites (staging):

Example	Example	Example

Non Verified sites (staging):

Example	Example	Example

• Confirmed the Rewards icon shows the correct notification count badge when there are Rewards notifications.
  • Confirmed the count decreases as notifications are removed from panel

Example	Example	Example	Example

• Confirmed hiding the rewards icon works
  • Confirmed when the Rewards icon is hidden in settings, the Rewards icon does not appear
  • Confirmed this selection is retained on relaunch
  • Confirmed able to hide rewards icon via right click on rewards icon in URL bar and via brave://settings/appearance

Example	Example

• Confirmed when the Rewards icon is hidden in settings:
  • the panel can still be opened from brave://settings/rewards (onboarding)
  • the panel can still be opened from NTP (onboarding)
  • the panel can still be opened from NTP (Ad grant claim)
  • the panel can still be opened from brave://rewards page (ad grant claim)
  • the panel can still be opened for adaptive captcha solving (see Adaptive Captcha section above)

Rewards icon off	brave://settings/rewards	NTP	NTP	brave://rewards

• Confirmed when in a "private" context (i.e. a private window or tor window), the Rewards icon does not appear.

Normal Window	Private Window	Guest Window	Tor Window

Additionally, special attention was given to the panel with the webui flag enabled while testing the following:

• Introduce "You've set up a pending tip" messaging for pending tip cases #20748 (comment)
• Make tipping banner response depend on success/error from server: Follow up to 15543 #19071 (comment)
• https://github.com/brave/internal/issues/890#issuecomment-1218370811

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 10 Version 21H2 (Build 19044.1889)

• Adaptive captcha items:
  • Confirmed received adaptive captcha at appropriate time when scheduled
  • Confirmed adaptive captcha is displayed correctly when the user clicks on the "Solve" button for adaptive captcha
  • Confirmed able to solve adaptive captcha successfully
  • Confirmed able to select "Later" and the prompt is displayed later
  • Confirmed able to fail captcha several times and then pass successfully
  • Confirmed if Rewards icon is hidden, when clicking on "Solve", the Rewards icon shows, the panel opens, and the adaptive captcha is displayed
  • Confirmed if I click "Solve" on the prompt, the adaptive captcha is shown on the panel. If I then close the panel, and reopen it - the adaptive captcha is still there, waiting to be solved.
  • Confirmed if the max attempts at the captcha are met without success, there is UI instructing the user to contact support
  • Confirmed the "Contact Support" button opens Brave Help Center in a new tab

Example	Example	Example	Example	Example

• Adaptive captcha items:
  • Confirmed received adaptive captcha at appropriate time when scheduled
  • Confirmed adaptive captcha is displayed correctly when the user clicks on the "Solve" button for adaptive captcha
  • Confirmed able to solve adaptive captcha successfully
  • Confirmed able to select "Later" and the prompt is displayed later
  • Confirmed able to fail captcha several times and then pass successfully
  • Confirmed if Rewards icon is hidden, when clicking on "Solve", the Rewards icon shows, the panel opens, and the adaptive captcha is displayed
  • Confirmed if I click "Solve" on the prompt, the adaptive captcha is shown on the panel. If I then close the panel, and reopen it the adaptive captcha is still there, waiting to be solved.
  • Confirmed if the max attempts at the captcha are met without success, there is UI instructing the user to contact support
  • FAILED - the "Contact Support" button does not open Brave Help Center in a new tab, encountered the issue "Contact Support" from adaptive captcha doesn't work with WebUI rewards panel #24846

Example	Example	Example	Example

[LaurenWags]

Per discussion with @zenparsing @Miyayes, removed the OS/Android tag as there were no Android changes with this issue.

cc @kjozwiak @srirambv @Uni-verse