Some blocked third-party cookies are visible in the cookies widget

[iefremov]

Description

Some third-party cookies are allowed even when shields prohibit them.

Steps to Reproduce

1. Google 'alexa top 500'
2. Click the first link
3. Check the site information balloon, you will see google cookies.

Actual result:

Expected result:

No 3rdparty cookies

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.57.4 Chromium: 71.0.3578.31 (Official Build) dev(64-bit)
Revision	c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS	Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  yes on dev, no on beta

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?
  n/a

Additional Information

Doesn't reproduce when navigating to alexa directly. Seems like the allowed/blocked cookies in TabSpecificContentSettings are not updated properly during tab navigations (see BraveContentBrowserClient).

[iefremov]

@bbondy FYI

[iefremov]

It seems that the bug is caused by a race condition in the Chromium code.

Adding delay to the beginning of ChromeNetworkDelegate::OnCanGetCookies reproduces the bug in Chromium. The task posted in this method arrives to TabSpecificContentSettings right after its state is cleared in ClearContentSettingsExceptForNavigationRelatedSettings (this happens as the reaction for DidStartNavigation).

Still need to figure out how to fix this. It would be nice to upstream the fix.

[iefremov]

Note: the bug actually doesn't affect the cookie store. The problem is related only to the cookie data shown in the page info widget (see the gif).

[iefremov]

fixed :D