Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom Brave Ad notifications should be attached to the browser window when repositioning ads on the screen #22216

Closed
btlechowski opened this issue Apr 11, 2022 · 2 comments
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@btlechowski
Copy link

Follow up to #19464.

Steps to Reproduce

  1. Clean install
  2. Run Brave with: --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"
  3. Enable rewards and ads
  4. Trigger a notification ad

Actual result:

Notification ad is attached to the screen when ad is moved rather than Brave Window
19464_Ubuntu_screen

Note: Notice that the ad is cropped, this is logged under #22206

Expected result:

Notification ad is attached to Brave Window when ad is moved

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS

cc @brave/qa-team @jsecretan @tmancey @aseren

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Mar 1, 2023
@tmancey tmancey changed the title custom ad notification is attached to screen rather than to Brave window when moving the ad Fix custom Brave Ad notifications are attached to screen rather than to Brave window when moving the ad Apr 13, 2023
@tmancey tmancey changed the title Fix custom Brave Ad notifications are attached to screen rather than to Brave window when moving the ad Fix custom Brave Ad notifications should be attached to the browser window when repositioning ads on the screen Apr 13, 2023
@aseren
Copy link

aseren commented Apr 14, 2023

As I understand, a custom ad notification should have the same Z-order as a browser window. But should be attached to the edges of the screen.
So it seems like we have a wrong feature parameter naming here. It should be something like same_zorder_browser_window.
cc @tmancey

@tmancey tmancey assigned tmancey and aseren and unassigned tmancey Apr 20, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Apr 20, 2023
@tmancey
Copy link
Contributor

tmancey commented Apr 20, 2023

Closed by #29744

@tmancey tmancey closed this as completed Apr 20, 2023
@kjozwiak kjozwiak removed the bug label Apr 27, 2023
@kjozwiak kjozwiak removed OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

4 participants