Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block cross-site cookies heading label should read Block cookies #22035

Closed
stephendonner opened this issue Apr 1, 2022 · 3 comments · Fixed by brave/brave-core#12862
Closed

Block cross-site cookies heading label should read Block cookies #22035

stephendonner opened this issue Apr 1, 2022 · 3 comments · Fixed by brave/brave-core#12862
Assignees
@Tonev
Labels
bug feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.38.x - Release

Comments

@stephendonner
Copy link

Description

Block cross-site cookies heading label should read Block cookies

Steps to Reproduce

  1. install 1.39.22
  2. launch Brave
  3. open brave://settings/shields
  4. read label and options for Block cross-site cookies

Actual result:

The label is Block cross-site cookies and includes...All and Only cross-site options, the latter of which is made redundant by the (incorrect) label

example example
Screen Shot 2022-04-01 at 12 11 36 AM Screen Shot 2022-04-01 at 12 11 45 AM

Expected result:

Label should probably just read Block cookies, which would fit with the other labels, as well as its own options

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.22 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 12.3 (Build 21E230)

cc @jenn-rhim @nullhook @pes10k @rebron @MadhaviSeelam @Tonev
@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified regression OS/Desktop labels Apr 1, 2022
@Tonev
Copy link
Contributor

Tonev commented Apr 1, 2022

Sorry, @stephendonner, I should have pinged you along @rebron and @nullhook 😞

#21983

@Tonev
Copy link
Contributor

Tonev commented Apr 1, 2022

Please, assist me with review/merge so we get this fixed 👉 brave/brave-core#12862

@rebron rebron mentioned this issue Apr 1, 2022
Closed
@bsclifton bsclifton mentioned this issue Apr 1, 2022
Merged
25 tasks
@bsclifton bsclifton added this to the 1.39.x - Nightly milestone Apr 2, 2022
@bsclifton bsclifton assigned Tonev and unassigned nullhook Apr 2, 2022
@nullhook nullhook mentioned this issue Apr 4, 2022
Merged
7 tasks
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed the label now reads Block cookies (highlight mine in screenshot)

Screen Shot 2022-04-07 at 9 28 21 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tonev Tonev

Labels
bug feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Change Block cross-site cookies to Block cookies at brave://settings/shields Tonev/brave-core
5 participants
@stephendonner @kjozwiak @bsclifton @nullhook @Tonev