Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Mac Nightly #21934

Closed
mkarolin opened this issue Mar 28, 2022 · 5 comments · Fixed by brave/brave-core#12984
Closed

Crash on Mac Nightly #21934

mkarolin opened this issue Mar 28, 2022 · 5 comments · Fixed by brave/brave-core#12984
Assignees
Labels
crash feature/shields The overall Shields feature in Brave. OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

Reported by @ShivanKaul:
I just got a crash when clicking on Brave Shields in Nightly for https://d3ward.github.io/toolz/adblock.html. I got it twice in a row but seems fine now.

Brave Version: 1.38.60  Chromium: 100.0.4896.46
Operating System: Mac OS X 11.6.0
Uploaded Crash Report ID:	70f40200-a473-f107-0000-000000000000

The crash stack tip:

1
<…>
‎/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../ui/base/resource/resource_bundle.cc:1162
2
l10n_util::GetStringUTF16
‎/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../ui/base/resource/resource_bundle.cc:771
3
…::ToolTask::ToolTask
‎/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../chrome/browser/task_manager/providers/web_contents/tool_task.cc:17
4
…::ToolTag::CreateTask
‎/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725
5
…::WebContentsEntry::CreateTaskForFrame
‎/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc:337
6
…::WebContentsObserverList::NotifyObservers<…>
‎/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../content/browser/web_contents/web_contents_impl.h:1516
7
<…>
@LaurenWags
Copy link
Member

cc @rebron since this is 1.38.x / shields v2

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 5, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 5, 2022

cc: @nullhook @petemill

@nullhook
Copy link

nullhook commented Apr 14, 2022

this should be fixed via brave/brave-core#12984

@kjozwiak
Copy link
Member

Above requires 1.38.102 or higher for 1.38.x verification.

@LaurenWags LaurenWags added the feature/shields The overall Shields feature in Brave. label Apr 19, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (x86_64)
Revision ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS macOS Version 11.6.5 (Build 20G527)

With both existing and new profiles, loaded https://d3ward.github.io/toolz/adblock.html and toggled Shields DOWN/UP without issue/crashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/shields The overall Shields feature in Brave. OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants