Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking/Blocking protections are not always disabled when Shields are turned off #2190

Closed
Brave-Matt opened this issue Nov 20, 2018 · 6 comments
Labels
bug closed/invalid feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/shields Shields is breaking a website.

Comments

@Brave-Matt
Copy link

Description

Possibly related issue here
Sometimes connections/calls are still getting blocked by Shields even when they're disabled.
Additional info courtesy of @jonathansampson:

The 412 is unrelated.
The page is attempting to redirect us to accounts.google.com.
That attempt gets stuck in the pending stage.
Likely due to our blocking. The initial call to accounts.google.com gets a 307 Internal Redirect, meaning the browser is redirecting the traffic. The call is still made, but never finishes. It just sits in the pending stage.

Steps to Reproduce

  1. Visit http://appinventor.mit.edu/explore/#
  2. Click the "Create apps" button on the top right
  3. Toggle Shields on/off

Actual result:

Page doesn't fully load, remains blank (but not an actual blank page).

Expected result:

Page should load and app creator (or something like that) should display.

Reproduces how often:

Easily

Brave version (brave://version info)

Release build, v0.56.12

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information

Short clips of actual vs expected behavior:

Chrome:
mitsitefail

Brave:
mitsitefail2

Console output:
image

Network Tab:
image

@Brave-Matt Brave-Matt added webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. labels Nov 20, 2018
@jonathansampson
Copy link
Contributor

Similar issues when using Ghostery: matomo-org/matomo#13018

@Brave-Matt
Copy link
Author

OG reddit post:
https://www.reddit.com/r/brave_browser/comments/9ylgf3/website_not_loading_http_412/

Also worth noting that the site functions as expected in Private window

@tildelowengrimm tildelowengrimm removed the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Nov 26, 2018
@tildelowengrimm tildelowengrimm added this to the 1.0 milestone Nov 26, 2018
@tildelowengrimm tildelowengrimm added bug feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 27, 2018
@Brave-Matt
Copy link
Author

+1 from Community I think? Hard to tell but given that this works in dev (see report) and no shields config, global or domain-level, has any effect this seems to be the culprit:
https://community.brave.com/t/bitchute-com-links-are-not-working-https-www-bitchute-com-video-5jnvhpmzpxrd/39715/6

@bbondy bbondy removed this from the 1.0 milestone Dec 20, 2018
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 2, 2019
@aghodsi
Copy link

aghodsi commented Jan 9, 2019

Hi,

I was the original reporter of this issue (on reddit). Just wanted to report that this seems to be resolved on the latest beta Version 0.59.21 Chromium: 72.0.3626.28 )

@tildelowengrimm
Copy link
Contributor

@brave/legacy_qa Can you verify?

@LaurenWags
Copy link
Member

@tomlowenthal worked for me with the following build

Brave 0.59.21 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 14, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/invalid feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/shields Shields is breaking a website.
Projects
None yet
Development

No branches or pull requests

8 participants