Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter swapAssetOptions by Network #21839

Closed
Douglashdaniel opened this issue Mar 24, 2022 · 3 comments · Fixed by brave/brave-core#12726
Closed

Filter swapAssetOptions by Network #21839

Douglashdaniel opened this issue Mar 24, 2022 · 3 comments · Fixed by brave/brave-core#12726
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Mar 24, 2022 •
edited
Loading

Description

swapAssetOptions is returning assets from all networks (chainId's), should only show assets for the SelectedNetwork
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 24, 2022
@Douglashdaniel Douglashdaniel self-assigned this Mar 24, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Mar 24, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.39.x - Nightly milestone Mar 24, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2022

Above requires 1.38.82 or higher for verification on 1.38.x.

@Uni-verse
Copy link
Contributor

Verified using

Brave 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 12.3.1 (Build 21E258)
  • Ensured assets options in swap are shown based on selected network
  • Verified assets option on Ropsten, Eth mainnet, BSC, Polygon, Fantom
21839_fix.mov

@LaurenWags LaurenWags mentioned this issue Apr 26, 2022
Closed
@Douglashdaniel
Copy link
Author

Changing to release-notes/exclude since this wasn't perceivable on Release channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Filter swapAssetOptions by Network brave/brave-core
3 participants
@kjozwiak @Uni-verse @Douglashdaniel