Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing serial comma in Brave Shields icon tooltip #21834

Closed
stephendonner opened this issue Mar 23, 2022 · 4 comments · Fixed by brave/brave-core#12747
Closed

Missing serial comma in Brave Shields icon tooltip #21834

stephendonner opened this issue Mar 23, 2022 · 4 comments · Fixed by brave/brave-core#12747
Assignees
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

stephendonner commented Mar 23, 2022

Description

Missing serial comma in Brave Shields icon tooltip

Per #17369 (comment)

Steps to Reproduce

  1. install 1.38.66
  2. launch Brave
  3. load a site with known trackers (cnn.com)
  4. hover over the Shields icon in the URL bar
  5. look at the tooltip text

Actual result:

X Trackers, ads and more blocked (note the missing serial/Harvard/Oxford comma)

Screen Shot 2022-03-23 at 11 22 37 AM

Expected result:

X Trackers, ads, and more blocked

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.66 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 12.3 (Build 21E230)

cc @nullhook @rmcfadden3

@stephendonner stephendonner added OS/Desktop needs-text-change This change requires some careful wording. QA/Yes QA/Test-Plan-Specified feature/shields The overall Shields feature in Brave. feature/shields/panel Front-end design and functionality of the Shields panel. labels Mar 23, 2022
@rmcfadden3
Copy link

Yes! Need this Oxford comma, plz!

@Tonev
Copy link
Contributor

Tonev commented Mar 25, 2022

@stephendonner

Feel free to assign me as I have an open pull request that will resolve the issue 👍

@stephendonner
Copy link
Author

stephendonner commented Mar 28, 2022

Verified PASSED using

Brave 1.39.7 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed the tooltip now reads Brave Shields X Trackers, ads, and more blocked (with the Oxford comma).

Screen Shot 2022-03-28 at 2 33 37 PM

Thanks @Tonev and @nullhook ❤️

@MadhaviSeelam
Copy link

Verified Passed using

Brave 1.39.10 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)

Confirmed the tooltip now reads Brave Shields X Trackers, ads, and more blocked (with the Oxford comma).

brave shields tooltip text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants