crash when clicking on the Control your music/playlist button

[kjozwiak]

Description

Pressing the Control your music/Playlist button with C100 instantly crashes Brave. Clicking in the button should display a card with a list of all the media that's currently opened with the ability to control what's being played/muting etc..

This only happens with C100 as I couldn't reproduce the issue using 1.38.57 Chromium: 99.0.4844.74. Unfortunately, it doesn't look like the crash has been symbolised on BackTrace.

• 1d4b0400-8c38-e807-0000-000000000000
• 1b4b0400-8c38-e807-0000-000000000000

Steps to Reproduce

1. launch a version of Brave that has C100 enabled (used 1.38.63 Chromium: 100.0.4896.46 in this case)
2. once launched, open YouTube and click on any random video
3. once the video is playing. open a NTP and click on the Control your media/Playlist button and Brave will instantly crash

Please see brave/brave-core#12709 (comment) for a few more cases to run through

Actual result:

Using the STR/Cases, you'll run into the following crashes:

• 1d4b0400-8c38-e807-0000-000000000000
• 1b4b0400-8c38-e807-0000-000000000000

Expected result:

Brave shouldn't be crashing when using the feature.

Reproduces how often:

100% reproducible using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.38.63 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 11 Version 21H2 (Build 22000.556)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A (doesn't have C100)
• Can you reproduce this issue with the beta channel? N/A (doesn't have C100)
• Can you reproduce this issue with the nightly channel? Yes (currently includes C100)

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

[rebron]

cc: @iefremov

[emerick]

Stack trace on Windows:

Backtrace:
        base::debug::CollectStackTrace [0x00007FFB6191FE12+18] (C:\work\brave-browser\src\base\debug\stack_trace_win.cc:305)
        base::debug::StackTrace::StackTrace [0x00007FFB617E8782+18] (C:\work\brave-browser\src\base\debug\stack_trace.cc:219)
        logging::LogMessage::~LogMessage [0x00007FFB6180922D+141] (C:\work\brave-browser\src\base\logging.cc:600)
        logging::LogMessage::~LogMessage [0x00007FFB6180A590+16] (C:\work\brave-browser\src\base\logging.cc:593)
        media_router::ChromeMediaRouterFactory::BuildServiceInstanceFor [0x00007FFB32574AF5+133] (C:\work\brave-browser\src\chrome\browser\media\router\chrome_media_router_factory.cc:70)
        BrowserContextKeyedServiceFactory::BuildServiceInstanceFor [0x00007FFB4DB320E8+24] (C:\work\brave-browser\src\components\keyed_service\content\browser_context_keyed_service_factory.cc:94)
        KeyedServiceFactory::GetServiceForContext [0x00007FFB70765065+293] (C:\work\brave-browser\src\components\keyed_service\core\keyed_service_factory.cc:80)
        media_router::MediaRouterFactory::GetApiForBrowserContext [0x00007FFB301A8E0C+100] (C:\work\brave-browser\src\components\media_router\browser\media_router_factory.cc:28)
        media_router::PresentationServiceDelegateImpl::PresentationServiceDelegateImpl [0x00007FFB301AF094+84] (C:\work\brave-browser\src\components\media_router\browser\presentation\presentation_service_delegate_impl.cc:315)
        content::WebContentsUserData<media_router::PresentationServiceDelegateImpl>::CreateForWebContents<> [0x00007FFB301AEF91+123] (C:\work\brave-browser\src\content\public\browser\web_contents_user_data.h:49)
        media_router::PresentationServiceDelegateImpl::GetOrCreateForWebContents [0x00007FFB301AEEF3+89] (C:\work\brave-browser\src\components\media_router\browser\presentation\presentation_service_delegate_impl.cc:307)
        media_router::WebContentsPresentationManager::Get [0x00007FFB301B7335+37] (C:\work\brave-browser\src\components\media_router\browser\presentation\web_contents_presentation_manager.cc:21)
        media_router::MediaRouterUI::MediaRouterUI [0x00007FFB330484E5+317] (C:\work\brave-browser\src\chrome\browser\ui\media_router\media_router_ui.cc:110)
        MediaNotificationService::CreateCastDialogControllerForSession [0x00007FFB32D81F6D+71] (C:\work\brave-browser\src\chrome\browser\ui\global_media_controls\media_notification_service.cc:343)
        MediaDialogView::BuildMediaItemUIView [0x00007FFB32D7DC04+364] (C:\work\brave-browser\src\chrome\browser\ui\views\global_media_controls\media_dialog_view.cc:419)
        MediaDialogView::ShowMediaItem [0x00007FFB32D7D91F+127] (C:\work\brave-browser\src\chrome\browser\ui\views\global_media_controls\media_dialog_view.cc:158)
        global_media_controls::MediaItemManagerImpl::SetDialogDelegate [0x00007FFB1D9E1B96+374] (C:\work\brave-browser\src\components\global_media_controls\media_item_manager_impl.cc:84)
        MediaDialogView::AddedToWidget [0x00007FFB32D7E172+162] (C:\work\brave-browser\src\chrome\browser\ui\views\global_media_controls\media_dialog_view.cc:205)
        views::View::PropagateAddNotifications [0x00007FFB5D59072A+202] (C:\work\brave-browser\src\ui\views\view.cc:2686)
        views::View::AddChildViewAtImpl [0x00007FFB5D5900D9+1001] (C:\work\brave-browser\src\ui\views\view.cc:2573)
        views::ClientView::ViewHierarchyChanged [0x00007FFB5D5A8D7A+202] (C:\work\brave-browser\src\ui\views\window\client_view.cc:91)
        views::DialogClientView::ViewHierarchyChanged [0x00007FFB5D5AC0C6+22] (C:\work\brave-browser\src\ui\views\window\dialog_client_view.cc:193)
        views::View::ViewHierarchyChangedImpl [0x00007FFB5D59056B+59] (C:\work\brave-browser\src\ui\views\view.cc:2704)
        views::View::PropagateAddNotifications [0x00007FFB5D59070E+174] (C:\work\brave-browser\src\ui\views\view.cc:2684)
        views::View::AddChildViewAtImpl [0x00007FFB5D5900D9+1001] (C:\work\brave-browser\src\ui\views\view.cc:2573)
        views::NonClientView::ViewHierarchyChanged [0x00007FFB5D5B46D9+89] (C:\work\brave-browser\src\ui\views\window\non_client_view.cc:312)
        views::View::ViewHierarchyChangedImpl [0x00007FFB5D59056B+59] (C:\work\brave-browser\src\ui\views\view.cc:2704)
        views::View::PropagateAddNotifications [0x00007FFB5D59070E+174] (C:\work\brave-browser\src\ui\views\view.cc:2684)
        views::View::AddChildViewAtImpl [0x00007FFB5D5900D9+1001] (C:\work\brave-browser\src\ui\views\view.cc:2573)
        views::internal::RootView::SetContentsView [0x00007FFB5D599C2C+204] (C:\work\brave-browser\src\ui\views\widget\root_view.cc:230)
        views::Widget::Init [0x00007FFB5D59DB1E+1182] (C:\work\brave-browser\src\ui\views\widget\widget.cc:408)
        views::BubbleDialogDelegate::CreateBubble [0x00007FFB5D4C4649+937] (C:\work\brave-browser\src\ui\views\bubble\bubble_dialog_delegate_view.cc:432)
        views::BubbleDialogDelegateView::CreateBubble [0x00007FFB5D4C4964+36] (C:\work\brave-browser\src\ui\views\bubble\bubble_dialog_delegate_view.cc:450)
        MediaDialogView::ShowDialog [0x00007FFB32D7D484+192] (C:\work\brave-browser\src\chrome\browser\ui\views\global_media_controls\media_dialog_view.cc:122)
        MediaDialogView::ShowDialogFromToolbar [0x00007FFB32D7D3BD+37] (C:\work\brave-browser\src\chrome\browser\ui\views\global_media_controls\media_dialog_view.cc:86)
        MediaToolbarButtonView::ButtonPressed [0x00007FFB32259B8E+110] (C:\work\brave-browser\src\chrome\browser\ui\views\global_media_controls\media_toolbar_button_view.cc:161)
        base::internal::Invoker<base::internal::BindState<`lambda at ../../ui/views/controls/button/button.cc:111:31',base::RepeatingCallback<void ()> >,void (const ui::Event &)>::Run [0x00007FFB5D4D7DCB+59] (C:\work\brave-browser\src\base\bind_internal.h:761)
        views::Button::NotifyClick [0x00007FFB5D4D6D44+180] (C:\work\brave-browser\src\ui\views\controls\button\button.cc:649)
        views::Button::DefaultButtonControllerDelegate::NotifyClick [0x00007FFB5D4D5288+24] (C:\work\brave-browser\src\ui\views\controls\button\button.cc:70)
        views::ButtonController::OnMousePressed [0x00007FFB5D4D90D8+232] (C:\work\brave-browser\src\ui\views\controls\button\button_controller.cc:41)
        ToolbarButton::OnMousePressed [0x00007FFB318E5801+353] (C:\work\brave-browser\src\chrome\browser\ui\views\toolbar\toolbar_button.cc:486)
        views::View::ProcessMousePressed [0x00007FFB5D58BA31+209] (C:\work\brave-browser\src\ui\views\view.cc:3010)
        views::View::OnMouseEvent [0x00007FFB5D58B87C+60] (C:\work\brave-browser\src\ui\views\view.cc:1436)
        ui::ScopedTargetHandler::OnEvent [0x00007FFB86B3BCD2+82] (C:\work\brave-browser\src\ui\events\scoped_target_handler.cc:30)
        ui::EventDispatcher::DispatchEvent [0x00007FFB86B35F3F+79] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:191)
        ui::EventDispatcher::ProcessEvent [0x00007FFB86B35C6F+303] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:140)
        ui::EventDispatcherDelegate::DispatchEventToTarget [0x00007FFB86B35A87+87] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:84)
        ui::EventDispatcherDelegate::DispatchEvent [0x00007FFB86B359BB+187] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:55)
        views::internal::RootView::OnMousePressed [0x00007FFB5D59A627+711] (C:\work\brave-browser\src\ui\views\widget\root_view.cc:419)
        views::Widget::OnMouseEvent [0x00007FFB5D5A321E+414] (C:\work\brave-browser\src\ui\views\widget\widget.cc:1520)
        views::DesktopNativeWidgetAura::OnMouseEvent [0x00007FFB5D5E6311+177] (C:\work\brave-browser\src\ui\views\widget\desktop_aura\desktop_native_widget_aura.cc:1240)
        ui::EventDispatcher::DispatchEvent [0x00007FFB86B35F3F+79] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:191)
        ui::EventDispatcher::ProcessEvent [0x00007FFB86B35C6F+303] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:140)
        ui::EventDispatcherDelegate::DispatchEventToTarget [0x00007FFB86B35A87+87] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:84)
        ui::EventDispatcherDelegate::DispatchEvent [0x00007FFB86B359BB+187] (C:\work\brave-browser\src\ui\events\event_dispatcher.cc:55)
        ui::EventProcessor::OnEventFromSource [0x00007FFB86B37202+530] (C:\work\brave-browser\src\ui\events\event_processor.cc:21)
        ui::EventSource::DeliverEventToSink [0x00007FFB86B3807D+125] (C:\work\brave-browser\src\ui\events\event_source.cc:118)
        ui::EventSource::SendEventToSinkFromRewriter [0x00007FFB86B37F84+372] (C:\work\brave-browser\src\ui\events\event_source.cc:146)
        ui::EventSource::SendEventToSink [0x00007FFB86B37E00+16] (C:\work\brave-browser\src\ui\events\event_source.cc:112)
        views::DesktopWindowTreeHostWin::HandleMouseEvent [0x00007FFB5D5EB8B0+64] (C:\work\brave-browser\src\ui\views\widget\desktop_aura\desktop_window_tree_host_win.cc:1005)
        views::HWNDMessageHandler::HandleMouseEventInternal [0x00007FFB5D5BC292+1138] (C:\work\brave-browser\src\ui\views\win\hwnd_message_handler.cc:3159)
        views::HWNDMessageHandler::_ProcessWindowMessage [0x00007FFB5D5BAC2F+271] (C:\work\brave-browser\src\ui\views\win\hwnd_message_handler.h:359)
        views::HWNDMessageHandler::OnWndProc [0x00007FFB5D5BA8D2+226] (C:\work\brave-browser\src\ui\views\win\hwnd_message_handler.cc:1026)
        gfx::WindowImpl::WndProc [0x00007FFB7154CCF8+216] (C:\work\brave-browser\src\ui\gfx\win\window_impl.cc:306)
        base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc> [0x00007FFB7154C3BF+15] (C:\work\brave-browser\src\base\win\wrapped_window_proc.h:77)
        CallWindowProcW [0x00007FFBA978E858+1016]
        DispatchMessageW [0x00007FFBA978E299+601]
        base::MessagePumpForUI::ProcessMessageHelper [0x00007FFB6192B72D+397] (C:\work\brave-browser\src\base\message_loop\message_pump_win.cc:542)
        base::MessagePumpForUI::ProcessNextWindowsMessage [0x00007FFB6192AC1E+318] (C:\work\brave-browser\src\base\message_loop\message_pump_win.cc:504)
        base::MessagePumpForUI::DoRunLoop [0x00007FFB6192A9AB+171] (C:\work\brave-browser\src\base\message_loop\message_pump_win.cc:215)
        base::MessagePumpWin::Run [0x00007FFB61929B61+113] (C:\work\brave-browser\src\base\message_loop\message_pump_win.cc:79)
        base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FFB618C3476+742] (C:\work\brave-browser\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:500)
        base::RunLoop::Run [0x00007FFB6185F50F+639] (C:\work\brave-browser\src\base\run_loop.cc:143)
        content::BrowserMainLoop::RunMainMessageLoop [0x00007FFB4E9B97BB+219] (C:\work\brave-browser\src\content\browser\browser_main_loop.cc:1058)
        content::BrowserMainRunnerImpl::Run [0x00007FFB4E9BBD55+149] (C:\work\brave-browser\src\content\browser\browser_main_runner_impl.cc:157)
        content::BrowserMain [0x00007FFB4E9B68F3+223] (C:\work\brave-browser\src\content\browser\browser_main.cc:30)
        content::RunBrowserProcessMain [0x00007FFB4F7119F3+331] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:642)
        content::ContentMainRunnerImpl::RunBrowser [0x00007FFB4F712FC6+1300] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:1175)
        content::ContentMainRunnerImpl::Run [0x00007FFB4F712A7F+639] (C:\work\brave-browser\src\content\app\content_main_runner_impl.cc:1046)
        content::RunContentProcess [0x00007FFB4F7113AC+1692] (C:\work\brave-browser\src\content\app\content_main.cc:401)
        content::ContentMain [0x00007FFB4F7114C4+84] (C:\work\brave-browser\src\content\app\content_main.cc:429)
        ChromeMain [0x00007FFB2F411281+481] (C:\work\brave-browser\src\chrome\app\chrome_main.cc:179)
        MainDllLoader::Launch [0x00007FF744D127A6+358] (C:\work\brave-browser\src\chrome\app\main_dll_loader_win.cc:167)
        wWinMain [0x00007FF744D11BD3+2996] (C:\work\brave-browser\src\chrome\app\chrome_exe_main_win.cc:382)
        __scrt_common_main_seh [0x00007FF744DBF4C6+262] (d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
        BaseThreadInitThunk [0x00007FFBA91F7034+20]
        RtlUserThreadStart [0x00007FFBA9AA2651+33]

[GeetaSarvadnya]

Reproduced on Windows 10 x64 - 1.38.65

[kjozwiak]

The above requires 1.37.104 or higher for 1.37.x verification.

[MadhaviSeelam]

Verified Passed using

Brave	1.37.105 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	Windows 11 Version 21H2 (Build 22000.556)

• Install 1.37.x
• Launch Brave
• Opened Youtube and played a random video
• Once the video is playing. opened a NTP and clicked on the Control your media/Playlist button, and Brave no longer crashes

ex1	ex2

[stephendonner]

Verification PASSED using

Brave	1.37.106 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	macOS Version 11.6.5 (Build 20G527)

Confirmed no crash when toggling pause, etc.

[btlechowski]

Verification passed on

Brave	1.37.107 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	Ubuntu 18.04 LTS