Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update first run dialog text on macOS and Linux #21804

Closed
rebron opened this issue Mar 22, 2022 · 2 comments · Fixed by brave/brave-core#12777
Closed

Update first run dialog text on macOS and Linux #21804

rebron opened this issue Mar 22, 2022 · 2 comments · Fixed by brave/brave-core#12777

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 22, 2022

Description

Update first run dialog text on macOS and Linux to match current Windows version.

Actual result:

131174148-cda8c7db-49a1-4d2f-9240-f1df0aac207b

Expected result:

158931105-bf6518bd-35e5-4f6f-bc87-87e213876986

Replace "Welcome to Brave" with "Ready for the best privacy online?"
Replace "To ensure the best privacy online..." with "Set Brave as your default browser..."

Brave version (brave://version info)

Target 1.37.x/1.38.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Related: #21694

@stephendonner
Copy link

Verified PASSED using

Brave 1.39.51 Chromium: 100.0.4896.88 (Official Build) nightly (x86_64)
Revision 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS macOS Version 11.6.5 (Build 20G527)

Light theme

focused unfocused
Screen Shot 2022-04-12 at 4 20 53 PM Screen Shot 2022-04-12 at 4 20 57 PM

Dark theme

focused unfocused
Screen Shot 2022-04-12 at 4 23 27 PM Screen Shot 2022-04-12 at 4 23 30 PM

@btlechowski
Copy link

Verification passed on

Brave 1.39.100 Chromium: 101.0.4951.61 (Official Build) beta (64-bit)
Revision 3b3633b32c491b4cba5fd7df3c7c0f628547cbcc-refs/branch-heads/4951@{#1189}
OS Ubuntu 18.04 LTS

Light mode:
image

Dark mode:
image

Polish locale:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants