Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some strings on webcompat reporter are not translated #21801

Closed
btlechowski opened this issue Mar 22, 2022 · 3 comments
Closed

Some strings on webcompat reporter are not translated #21801

btlechowski opened this issue Mar 22, 2022 · 3 comments

Comments

@btlechowski
Copy link

Follow up to #20095

Steps to Reproduce

  1. Run Brave in Polish PL locale
  2. Open a page
  3. Click hamburger menu
  4. Click Zgłoś uszkodzoną stronę

Actual result:

Some strings are not translated:
image

Expected result:

All strings are translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.37.100 Chromium: 99.0.4844.83 (Oficjalna wersja) beta (64-bitowa)
Revision b11086e62d7c1a44b0942ac5568d22a425c7ae35-refs/branch-heads/4844_74@{#5}
OS Ubuntu 18.04 LTS

cc @brave/qa-team @rebron @mkarolin @pes10k @DJAndries

@kjozwiak
Copy link
Member

Removing as this isn't labelled as release/blocking. @rebron looks like this was moved into in progress via the General board. If this is going to be fixed with the l10n order, than the issue should be mentioned during uplift at which point, it will be moved into 1.37.x. If it needs a PR/uplift, it will go through the normal uplift process and moved into 1.37.x once uplifted.

@kjozwiak kjozwiak removed this from the 1.37.x - Release milestone Mar 23, 2022
@mkarolin
Copy link
Contributor

All these string have translations on Transifex, so they should come down with the next pull.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 25, 2022
@btlechowski
Copy link
Author

Verification passed on

Brave 1.37.109 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants