Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Scrolling Buttons functionality is broken #21757

Open
brzzdev opened this issue Mar 18, 2022 · 2 comments
Open

Tab Scrolling Buttons functionality is broken #21757

brzzdev opened this issue Mar 18, 2022 · 2 comments
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion

Comments

@brzzdev
Copy link

brzzdev commented Mar 18, 2022

Description

When the Brave flag 'Tab Scrolling' is enabled (I have it set to shrink to a large width fwiw), 'Scrolling Buttons' are broken no matter what settings you use. 'Default' they appear and aren't functional, 'On' they appear and aren't functional, 'Disabled' they still appear and aren't functional.

Steps to Reproduce

  1. Enable Tab Scrolling flag (#scrollable-tabstrip) (Broken on at least large)
  2. Open enough new tabs to have them be scrollable
  3. Buttons don't function
  4. Disable Scrolling Buttons (#scrollable-tabstrip-buttons)
  5. Buttons are still visible and still don't function.

Actual result:

Buttons don't function normally, nor hide when disabled.

Expected result:

Buttons should function. Buttons shouldn't appear when disabled.

Reproduces how often:

Constant

Brave version (brave://version info)

Brave 1.36.117 Chromium: 99.0.4844.74 (Official Build) (arm64)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS macOS Version 12.3 (Build 21E230)

Version/Channel Information:

Have noticed it for many versions

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Don't have
  • Can you reproduce this issue with the nightly channel? Don't have

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No
@rebron
Copy link
Collaborator

rebron commented Mar 18, 2022

Hi @PaulDoesDev. Flags aren't supported features.

@rebron rebron added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion labels Mar 18, 2022
@NicolasGoeddel
Copy link

Hi @PaulDoesDev. Flags aren't supported features.

And when will tab scrolling be a supported feature? When I got 200 open tabs they just don't fit in there. They have to scroll. Also they need to have a certain width to be readable. I like it how Firefox does it and I try to achieve the same on Brave. As long as this does not work they is no way to migrate to Brave for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion
Projects
None yet
Development

No branches or pull requests

3 participants