-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar as way to manage bookmarks and access favorite websites #21699
Comments
Latest designs matching production in this Figma page: |
Verification PASSED on
General testing on sidebar settingsVerify global sidebar settings and sidebar settings in hamburger menu_PASSED
Clean profileCase 1: Sidebar_Add/remove/reorder the websites favicons_PASSEDAdd
Remove:
Reorder:
Case 2: Sidebar_Bookmarks settings_PASSEDImport BM
Add bookmarks
Re-order
Remove
Re-order bookmarks icon in the sidebar menu
Case 3: Sidebar_Brave talk settings_PASSED
Case 4: Sidebar_Brave wallet settings_PASSED
Case 5: Sidebar_TOR/Private windows_PASSED
Upgrade profileUpgrade profile_PASSED
|
Verification Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (64-bit) Logged #21859 Prerequisite: Install
- Launch Brave
- Click on Brave Talk icon on the `Sidebar`
- The icon is highlighted in red and Brave talk home page should be displayed
|
Verification passed on
- Launch Brave
- Click on Brave Talk icon on the `Sidebar`
- The icon is highlighted in red and Brave talk home page should be displayed
|
Verification
- Launch Brave
- Click on Brave Talk icon on the `Sidebar`
- The icon is highlighted in red and Brave talk home page should be displayed
|
Description
Add a sidebar to normal window, private window, and private window with Tor to provide users the ability to access their favorite websites.
A user will be able to add a site/url to the sidebar which will then display the website favicon. If no favicon is available an icon with the sites' first letter will be generated. A user will be able remove and reorder via drag and drop these website icons. We will provider an overflow UX to allow users to add sites beyond the visible window size.
Add a bookmarks sidebar panel to allow users to add, delete, rename, drag and drop, and organize their bookmarks from the panel. Selecting bookmarks from the sidebar will open and close a bookmarks sidebar panel.
The sidebar will special case three items, Brave Talk, Brave Wallet, and Bookmarks. If a user removes any of those items, a user can re-add via add to sidebar bubble
Sidebar will provide access to Brave Talk and Brave Wallet. When selected for the first time, clicking on the icon will open up a new Brave Talk page or Brave Wallet page. When either Brave Talk or Brave Wallet is selected again, we will set focus on the existing page (rather than opening up a new page).
Sidebar settings will be available from the hamburger menu and in brave://settings/appearance to show, never show, or show on mouseover.
This will constitute version 1 of the sidebar.
Design/Expected Result:
https://www.figma.com/file/xOdKFSr3P5AXSAbP2r8ung/Sidebar-Desktop?node-id=880%3A32542
Brave version (brave://version info)
Targeted for release in 1.37
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: