-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't impose WebSockets limits on Extensions #21661
Comments
@goodov 👋 mind rounding our a test plan for this? cc @brave/qa-team and setting |
This can be tested by running a simple extension which creates WebSocket connections and shows that there are no limits (it can create much more than 10 connections). Extension for test: ws-extension-test.zip |
Verified
Steps:
Confirmed we hit well over 10; in my limited testrun, it took until
|
@goodov asking on behalf of @brave/qa-team - are there really (easily) testable Android steps, here? 🙏 |
There're no extensions, so this task is not applicable for Android. |
Linking confirmation that this is resolved from #19990 (comment) |
Verified
Confirmed we hit well over 10.
|
Verification passed on
Confirmed I hit well over 10; |
Currently we limit WebSockets connections for Extensions as part of #19990 implementation. We don't need to do this.
See #19990 (comment)
The text was updated successfully, but these errors were encountered: