Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need proper text alignment for really long token names #21659

Closed
srirambv opened this issue Mar 15, 2022 · 1 comment · Fixed by brave/brave-core#12639
Closed

Need proper text alignment for really long token names #21659

srirambv opened this issue Mar 15, 2022 · 1 comment · Fixed by brave/brave-core#12639
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-macOS QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Need proper text alignment for really long token names

Steps to Reproduce

  1. Add custom networks (BSC)
  2. Open Swap Tab and scroll down the token list
  3. Tokens with long name aren't properly aligned

Actual result:

Long.Token.Names.mov

Note: Not an issue on panel

Panel Swap Widget

Expected result:

Proper text alignment for long named tokens

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.43 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 11 Version 22H2 (Build 22572.1)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @Douglashdaniel @josheleonard

@Uni-verse
Copy link
Contributor

Verified using

Brave 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 12.3.1 (Build 21E258)
  • Using STR from above, verified long token names are aligned properly (left)
21659.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-macOS QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants