Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] Estimate Rewards performance impact #21602

Open
atuchin-m opened this issue Mar 11, 2022 · 3 comments
Open

[perf] Estimate Rewards performance impact #21602

atuchin-m opened this issue Mar 11, 2022 · 3 comments
Assignees
@atuchin-m
Labels
dev-concern feature/ads OS/Desktop perf

Comments

@atuchin-m
Copy link
Contributor

  1. Make a manual comparison Brave with/without rewards in terms of memory, CPU usage, and browsing speed.
  2. Enable Rewards in some perf test configuration (=Rewards/BAT code should be covered by perf tests).
@atuchin-m atuchin-m self-assigned this Mar 11, 2022
@atuchin-m
Copy link
Contributor Author

Bat Ads Service consumes a lot of memory (Private memory footprint is 33Mb). Most of the memory is taken when it loads the components (Brave Ads Resources (en + us): +24Mb private bytes
image
image

@atuchin-m
Copy link
Contributor Author

Moreover it has peak consumption about ~200MB:
image

@atuchin-m atuchin-m mentioned this issue Mar 29, 2022
Closed
@atuchin-m
Copy link
Contributor Author

  1. The ads memory consumption is optimized here: Optimize text_classifer model memory usage #21960
    After added CPU/memory consumptions looks acceptable, expected peak usage by JSON parse (the model format better t be changed)
  2. Added in brave-typical perf profile by enabling it manually. Better to use a cmd switch to enable ads/rewards automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
dev-concern feature/ads OS/Desktop perf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @atuchin-m