-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the dropdown label string 'State level ad targeting' in brave://rewards ads settings #21291
Comments
Seems like a good idea to me. How about replacing with the concept of "relevancy" instead? So "State-level ad relevance" |
In the not too distant future we will also have provinces for Canada so from a development point of view we need to make sure translators are aware, i.e. Province-level ad relevance for Canada. County-level ad relevance for the UK etc. |
@tmancey — good callout. In that case, could generalize to "Location-level ad relevance" |
@rmcfadden3 https://en.wikipedia.org/wiki/ISO_3166-2 is the iso standard for identifying the principal subdivisions. i.e. provinces, states, parishes etc. |
@rmcfadden3 what do you think of "Regional ad relevance" for the title and "This allows Brave to show you ads meant specifically for your region." for the description |
@tmancey — I'm good with that. |
Verified
NOTE: filed #22001 to cover the missed Verification PASSED on
|
Verification passed on
|
Replace the term 'targeting' in our labels to avoid association with the non-private ad targeting
@tmancey @jsecretan @rmcfadden3
The text was updated successfully, but these errors were encountered: