Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.ethereum is not available after reloading page for default wallet setting changes #20993

Closed
spylogsster opened this issue Feb 9, 2022 · 1 comment · Fixed by brave/brave-core#12193

Comments

@spylogsster
Copy link

Description

if users have opened tabs that work with window.ethereum object and enable native Brave Wallet using another tab then the object will not be available after reloading tabs. it becomes available only after opening a new instance of tabs.

Steps to Reproduce

  1. Set Wallet type preference to None
  2. Open chainlist.org in a new tab
  3. Set Wallet type preference to Brave Wallet
  4. Go to tab with chainlist.org and reload it
  5. check window.ethereum object in console

Actual result:

the object is not available

Expected result:

the object available and work as expected

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#12193
  • Verified when default provider is set to None, window.ethereum returns undefined
  • Verified after changing default provider from None to Brave Wallet, window.ethereum returns a response when the same page is reloaded
20993-Linux.mp4
20993-Windows.mov
20993-macOS.mov

@bbondy bbondy changed the title window.ethereum is not available after reloading page window.ethereum is not available after reloading page for default wallet setting changes Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants