Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Brave Ads DoesAdTypeSupportFrequencyCapping #20983

Closed
tmancey opened this issue Feb 8, 2022 · 1 comment · Fixed by brave/brave-core#12187
Closed

Deprecate Brave Ads DoesAdTypeSupportFrequencyCapping #20983

tmancey opened this issue Feb 8, 2022 · 1 comment · Fixed by brave/brave-core#12187
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop perf priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 8, 2022 •
edited
Loading

Deprecate Brave Ads DoesAdTypeSupportFrequencyCapping as no longer required as capping is handled on a per ad type basis in eligible_* classes.

This work is required as part of NTP SI ad and Brave Search ad changes where the ads library if enabled will serve ads
@tmancey tmancey added release-notes/exclude QA/Yes priority/P4 Planned work. We expect to get to it "soon". labels Feb 8, 2022
@tmancey tmancey self-assigned this Feb 8, 2022
@tmancey tmancey mentioned this issue Feb 9, 2022
Merged
25 tasks
@tmancey tmancey added the perf label Feb 9, 2022
@tmancey tmancey added this to the 1.37.x - Nightly milestone Feb 9, 2022
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 28, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#12187

Notification ads

conversion frequency cap

[27344:27344:0314/130458.009297:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[27344:27344:0314/130458.010444:VERBOSE1:eligible_ad_notifications_v1.cc(83)] Get eligible ads for parent-child segments:
[27344:27344:0314/130458.010511:VERBOSE1:eligible_ad_notifications_v1.cc(85)]   technology & computing-software
[27344:27344:0314/130458.010577:VERBOSE1:eligible_ad_notifications_v1.cc(85)]   technology & computing-freeware
[27344:27344:0314/130458.010623:VERBOSE1:eligible_ad_notifications_v1.cc(85)]   sports-golf
[27344:27344:0314/130458.011733:VERBOSE1:eligible_ad_notifications_v1.cc(103)] No eligible ads out of 0 ads for parent-child segments
[27344:27344:0314/130458.011808:VERBOSE1:eligible_ad_notifications_v1.cc(128)] Get eligible ads for parent segments:
[27344:27344:0314/130458.011865:VERBOSE1:eligible_ad_notifications_v1.cc(130)]   technology & computing
[27344:27344:0314/130458.011903:VERBOSE1:eligible_ad_notifications_v1.cc(130)]   sports
[27344:27344:0314/130458.011948:VERBOSE1:eligible_ad_notifications_v1.cc(130)]   personal finance
[27344:27344:0314/130458.012612:VERBOSE1:eligible_ad_notifications_v1.cc(147)] No eligible ads out of 0 ads for parent segments
[27344:27344:0314/130458.012702:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[27344:27344:0314/130458.013478:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId 76a65acb-64e2-4bbb-87a5-47b9050b69c9 has exceeded the conversions frequency cap

daily frequency cap (campaign)

[27763:27763:0314/132242.946767:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[27763:27763:0314/132242.947645:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[27763:27763:0314/132242.948547:VERBOSE2:exclusion_rules_base.cc(127)] campaignId 0d01425b-c970-4a25-b2d0-ccf748cfaf6e has exceeded the dailyCap frequency cap

day frequency cap (creative set)

[28634:28634:0314/123722.375040:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[28634:28634:0314/123722.376112:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[28634:28634:0314/123722.377256:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b has exceeded the perDay frequency cap

per hour frequency cap (creative_instance_id)

[29514:29514:0314/125840.888478:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[29514:29514:0314/125840.889603:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[29514:29514:0314/125840.891247:VERBOSE2:exclusion_rules_base.cc(127)] creativeInstanceId 5b4cb3f4-5285-4597-87c5-3082fe37938a has exceeded the perHour frequency cap

per month frequency cap (creative set)

[4718:4718:0314/152943.815258:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[4718:4718:0314/152943.817249:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[4718:4718:0314/152943.818432:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b has exceeded the perMonth frequency cap

per week frequency cap (creative set)

[5120:5120:0314/163625.731074:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[5120:5120:0314/163625.732588:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[5120:5120:0314/163625.735184:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b has exceeded the perWeek frequency cap

total max frequency cap (creative set)

[2964:2964:0314/182725.468510:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[2964:2964:0314/182725.469341:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[2964:2964:0314/182725.470291:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b has exceeded the totalMax frequency cap

transferred frequency cap (campaign)

[3970:3970:0314/183935.671858:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[3970:3970:0314/183935.673028:VERBOSE1:eligible_ad_notifications_v1.cc(83)] Get eligible ads for parent-child segments:
[3970:3970:0314/183935.673121:VERBOSE1:eligible_ad_notifications_v1.cc(85)]   history-history
[3970:3970:0314/183935.673167:VERBOSE1:eligible_ad_notifications_v1.cc(85)]   arts & entertainment-arts & entertainment
[3970:3970:0314/183935.673263:VERBOSE1:eligible_ad_notifications_v1.cc(85)]   sports-olympics
[3970:3970:0314/183935.674047:VERBOSE1:eligible_ad_notifications_v1.cc(103)] No eligible ads out of 0 ads for parent-child segments
[3970:3970:0314/183935.674131:VERBOSE1:eligible_ad_notifications_v1.cc(128)] Get eligible ads for parent segments:
[3970:3970:0314/183935.674189:VERBOSE1:eligible_ad_notifications_v1.cc(130)]   history
[3970:3970:0314/183935.674257:VERBOSE1:eligible_ad_notifications_v1.cc(130)]   arts & entertainment
[3970:3970:0314/183935.674314:VERBOSE1:eligible_ad_notifications_v1.cc(130)]   sports
[3970:3970:0314/183935.674851:VERBOSE1:eligible_ad_notifications_v1.cc(147)] No eligible ads out of 0 ads for parent segments
[3970:3970:0314/183935.674920:VERBOSE1:eligible_ad_notifications_v1.cc(164)] Get eligible ads for untargeted segment
[3970:3970:0314/183935.677120:VERBOSE2:exclusion_rules_base.cc(127)] campaignId 0d01425b-c970-4a25-b2d0-ccf748cfaf6e has exceeded the transferred frequency cap

per hour permission rule

[8581:8581:0328/193205.439646:VERBOSE2:permission_rule_util.cc(25)] You have exceeded the allowed ads per hour
[8581:8581:0328/193205.439823:VERBOSE1:ad_notification_serving.cc(117)] Ad notification not served: Not allowed due to permission rules

Inline ads

conversion frequency cap

[9512:9512:0316/224258.587736:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[9512:9512:0316/224258.589017:VERBOSE1:eligible_inline_content_ads_v1.cc(89)] Get eligible ads for parent-child segments:
[9512:9512:0316/224258.589054:VERBOSE1:eligible_inline_content_ads_v1.cc(91)]   technology & computing-software
[9512:9512:0316/224258.589088:VERBOSE1:eligible_inline_content_ads_v1.cc(91)]   technology & computing-technology & computing
[9512:9512:0316/224258.589109:VERBOSE1:eligible_inline_content_ads_v1.cc(91)]   business-business
[9512:9512:0316/224258.591331:VERBOSE1:eligible_inline_content_ads_v1.cc(110)] No eligible ads out of 0 ads for parent-child segments
[9512:9512:0316/224258.591400:VERBOSE1:eligible_inline_content_ads_v1.cc(136)] Get eligible ads for parent segments:
[9512:9512:0316/224258.591457:VERBOSE1:eligible_inline_content_ads_v1.cc(138)]   technology & computing
[9512:9512:0316/224258.591490:VERBOSE1:eligible_inline_content_ads_v1.cc(138)]   business
[9512:9512:0316/224258.591537:VERBOSE1:eligible_inline_content_ads_v1.cc(138)]   personal finance
[9512:9512:0316/224258.593232:VERBOSE1:eligible_inline_content_ads_v1.cc(156)] No eligible ads out of 0 ads for parent segments
[9512:9512:0316/224258.593293:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[9512:9512:0316/224258.596610:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId 76a65acb-64e2-4bbb-87a5-47b9050b69c9 has exceeded the conversions frequency cap

daily frequency cap (campaign)

[10238:10238:0316/225221.747011:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[10238:10238:0316/225221.748616:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[10238:10238:0316/225221.750712:VERBOSE2:exclusion_rules_base.cc(127)] campaignId 9bb85ea3-f510-4047-8cbb-4ba40fe3e84d has exceeded the dailyCap frequency cap

day frequency cap (creative set)

[12461:12461:0316/230315.849261:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[12461:12461:0316/230315.850324:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[12461:12461:0316/230315.851435:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId 76a65acb-64e2-4bbb-87a5-47b9050b69c9 has exceeded the perDay frequency cap

per hour frequency cap (creative_instance_id)

[19334:19334:0316/224942.678448:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[19334:19334:0316/224942.679565:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[19334:19334:0316/224942.682192:VERBOSE2:exclusion_rules_base.cc(127)] creativeInstanceId 04064736-ea43-463a-bd6e-6c2be4408b4d has exceeded the perHour frequency cap

per month frequency cap (creative set)

[13465:13465:0316/231311.652070:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[13465:13465:0316/231311.653555:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[13465:13465:0316/231311.655569:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId 76a65acb-64e2-4bbb-87a5-47b9050b69c9 has exceeded the perMonth frequency cap

per week frequency cap (creative set)

[16825:16825:0316/232826.988141:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[16825:16825:0316/232826.989721:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[16825:16825:0316/232826.991001:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId 76a65acb-64e2-4bbb-87a5-47b9050b69c9 has exceeded the perWeek frequency cap

total max frequency cap (creative set)

[18121:18121:0316/233339.158226:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[18121:18121:0316/233339.159274:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[18121:18121:0316/233339.160328:VERBOSE2:exclusion_rules_base.cc(127)] creativeSetId 76a65acb-64e2-4bbb-87a5-47b9050b69c9 has exceeded the totalMax frequency cap

transferred frequency cap (campaign)

[18479:18479:0316/224639.217074:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[18479:18479:0316/224639.218686:VERBOSE1:eligible_inline_content_ads_v1.cc(89)] Get eligible ads for parent-child segments:
[18479:18479:0316/224639.218748:VERBOSE1:eligible_inline_content_ads_v1.cc(91)]   other-other
[18479:18479:0316/224639.218835:VERBOSE1:eligible_inline_content_ads_v1.cc(91)]   technology & computing-software
[18479:18479:0316/224639.218883:VERBOSE1:eligible_inline_content_ads_v1.cc(91)]   careers-careers
[18479:18479:0316/224639.220150:VERBOSE1:eligible_inline_content_ads_v1.cc(110)] No eligible ads out of 0 ads for parent-child segments
[18479:18479:0316/224639.220186:VERBOSE1:eligible_inline_content_ads_v1.cc(136)] Get eligible ads for parent segments:
[18479:18479:0316/224639.220223:VERBOSE1:eligible_inline_content_ads_v1.cc(138)]   other
[18479:18479:0316/224639.220243:VERBOSE1:eligible_inline_content_ads_v1.cc(138)]   technology & computing
[18479:18479:0316/224639.220273:VERBOSE1:eligible_inline_content_ads_v1.cc(138)]   careers
[18479:18479:0316/224639.221027:VERBOSE1:eligible_inline_content_ads_v1.cc(156)] No eligible ads out of 0 ads for parent segments
[18479:18479:0316/224639.221069:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[18479:18479:0316/224639.222363:VERBOSE2:exclusion_rules_base.cc(127)] campaignId 1c1ac828-db13-49bb-9128-090132044b7f has exceeded the transferred frequency cap

NTPSI ads

Note: exclusion rules (conversion frequency cap etc) are not yet applied to NTPSI, this is by design

per day permission rule

[8114:8114:0318/191347.544384:VERBOSE2:permission_rule_util.cc(25)] You have exceeded the allowed new tab page ads per day
[8114:8114:0318/191347.544800:VERBOSE1:new_tab_page_ad.cc(54)] New tab page ad: Not allowed due to permission rules

per hour permission rule

[8114:8114:0318/201347.235783:VERBOSE2:permission_rule_util.cc(25)] You have exceeded the allowed new tab page ads per hour
[8114:8114:0318/201347.884939:VERBOSE1:new_tab_page_ad.cc(54)] New tab page ad: Not allowed due to permission rules

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 28, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop perf priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Deprecate Brave Ads DoesAdTypeSupportFrequencyCapping brave/brave-core
2 participants
@tmancey @btlechowski