Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Icon Needs Dark Theme #20859

Closed
Douglashdaniel opened this issue Feb 3, 2022 · 1 comment · Fixed by brave/brave-core#12117
Closed

Settings Icon Needs Dark Theme #20859

Douglashdaniel opened this issue Feb 3, 2022 · 1 comment · Fixed by brave/brave-core#12117
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

The settings icon for Advanced Settings in the Confirm Transaction panel needs to be updated for Dark Themes

Screen Shot 2022-02-02 at 5 44 26 PM
Screen Shot 2022-02-02 at 5 48 33 PM
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 3, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 3, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 3, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 3, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 28, 2022 •
edited
Loading

Verification completed using

Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | macOS Version 12.1 (Build 21C52)
  • Setting icon is displayed in dark theme
  • Settings icon is functional

Screen Shot 2022-03-28 at 11 32 22 AM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Fix Advanced Settings Icon Dark Theme brave/brave-core
2 participants
@Uni-verse @Douglashdaniel