Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out Hide Balances Feature in Wallet #20838

Closed
Douglashdaniel opened this issue Feb 2, 2022 · 1 comment · Fixed by brave/brave-core#12111
Closed

Build out Hide Balances Feature in Wallet #20838

Douglashdaniel opened this issue Feb 2, 2022 · 1 comment · Fixed by brave/brave-core#12111
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

Build out Hide Balances Feature in Wallet

Screen Shot 2022-02-01 at 6 12 41 PM
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 2, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 2, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 2, 2022
Merged
24 tasks
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 4, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@Uni-verse
Copy link
Contributor

Verification completed using

Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | macOS Version 12.1 (Build 21C52)
  • Verified hiding balances on portfolio page
  • Hiding balance in portfolio will also apply when opening asset page
  • Verified able to hide balances on asset page

Screen Shot 2022-03-28 at 11 51 39 AM
Screen Shot 2022-03-28 at 11 52 10 AM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Hide Balances Button to Portfolio Page brave/brave-core
3 participants
@bbondy @Uni-verse @Douglashdaniel