Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions text need proper text alignment on default window size #20774

Closed
srirambv opened this issue Jan 28, 2022 · 1 comment · Fixed by brave/brave-core#15364
Closed

Transactions text need proper text alignment on default window size #20774

srirambv opened this issue Jan 28, 2022 · 1 comment · Fixed by brave/brave-core#15364
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.46.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Transactions text need proper text alignment on default window size

Steps to Reproduce

  1. Perform a transaction on wallet
  2. Drag the window size to reduce width
  3. At a certain point the text alignment goes off

Actual result:

Transaction.Alignment.mov

Expected result:

No change in text alignment

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.35.93 Chromium: 97.0.4692.99 (Official Build) beta (arm64)
Revision d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @onyb @jamesmudgett
@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jan 28, 2022
@srirambv srirambv mentioned this issue Jan 28, 2022
Closed
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 18, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@josheleonard josheleonard self-assigned this Oct 5, 2022
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Oct 5, 2022
@josheleonard josheleonard mentioned this issue Oct 5, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 Oct 6, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 6, 2022
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from issue description
  • Verified transaction text is properly aligned irrespecitive of how browser window size
  • Encountered #26367
20774.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description
  • Verified transaction text is properly aligned irrespecitive of how browser window size
  • Encountered #26367
20774.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description
  • Verified transaction text is properly aligned irrespecitive of how browser window size
  • Encountered #26367
20744.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

fix: prevent bad text alignment in portfolio Txs brave/brave-core
4 participants
@bbondy @srirambv @josheleonard @brave-builds