Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector moved out of bounds #20681

Closed
spylogsster opened this issue Jan 25, 2022 · 1 comment · Fixed by brave/brave-core#11986
Closed

Selector moved out of bounds #20681

spylogsster opened this issue Jan 25, 2022 · 1 comment · Fixed by brave/brave-core#11986
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@spylogsster
Copy link

Description

In narrow windows selector is moved out of overlay borders
image

Steps to Reproduce

  1. open imported accounts
  2. make window narrow
  3. check derivation path selector position

Actual result:

wrong selector position

Expected result:

selector inside overlay

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@spylogsster spylogsster added the front-end-change This task is a front end task and doesn't need any C++ changes label Jan 25, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 25, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 25, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 26, 2022
@stephendonner stephendonner added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 26, 2022
@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11986
  • Verified reducing the window size to the smallest possible width doesn't cause the selector to be misaligned
20681-Linux.mp4
20681-Windows.mov
20681-macOS.mov

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Connect Hardware Modal Style Bugs brave/brave-core
4 participants
@stephendonner @spylogsster @srirambv @Douglashdaniel