Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add UI messaging/design that tells users they have 90 days to claim ad earnings and solve CAPTCHA #20626

Closed
Miyayes opened this issue Jan 21, 2022 · 3 comments · Fixed by brave/brave-core#16232
Closed

[Android] Add UI messaging/design that tells users they have 90 days to claim ad earnings and solve CAPTCHA #20626

Miyayes opened this issue Jan 21, 2022 · 3 comments · Fixed by brave/brave-core#16232
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude rewards-2.0
Milestone
1.48.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 21, 2022 •
edited
Loading

Description

Android version of #17133.

I believe we inherit the settings page changes. The NTP Rewards widget changes are irrelevant on Android. Only changes needed are on Rewards panel (toast notification).

image
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality rewards-2.0 labels Jan 21, 2022
@Miyayes Miyayes assigned deeppandya and zenparsing and unassigned zenparsing Jan 21, 2022
@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Jan 26, 2022
@Miyayes Miyayes added the QA/Yes label Jan 28, 2022
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Apr 15, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Apr 15, 2022

Right now, the claim button looks like this, which should be updated to be much closer to design spec and desktop:
image

@deeppandya

@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 28, 2022
@Miyayes Miyayes mentioned this issue Sep 24, 2022
Closed
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Sep 24, 2022
@deeppandya deeppandya mentioned this issue Dec 6, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 6, 2022
@stephendonner
Copy link

Verified PASSED using Brave 1.48.140, Chromium 109.0.5414.119 on a Google Pixel XL running Android 9

Steps:

  1. installed 1.47.161
  2. launched Brave
  3. through the QA Debug menu, enabled Rewards staging
  4. relaunched
  5. had @LaurenWags set up on ad grant for me on staging
  6. confirmed I saw a pending ad-grant notification on the BAT icon in the URL bar
  7. installed 1.48.140 atop of 1.47.161 (both are beta-channel builds)
  8. relaunched Brave
  9. tapped the BAT icon
  10. tapped CLAIM for the 3.250 BAT ad grant

Confirmed the new UI and that 3.250 BAT was added to my profile

pending ad grant claimed ad grant screencast
Screenshot_20230125-113235 Screenshot_20230125-113248
20230125_113157.mp4

@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 25, 2023

Also, as of late 1.49.x, this will no longer be relevant, since vBAT payouts will be no more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude rewards-2.0
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Implement Rewards 2.5 user states brave/brave-core
7 participants
@stephendonner @deeppandya @zenparsing @Miyayes @LaurenWags @sujitacharya2005 @brave-builds