Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave now no longer allow users to remove or delete default search engines #20530

Closed
manikandancode opened this issue Jan 17, 2022 · 2 comments
Closed

Comments

@manikandancode
Copy link

Browsers based on Chromium will no longer allow users to delete default search engines (that comes with default installation) from the settings.

brave://settings/searchEngines

brave_search

https://bugs.chromium.org/p/chromium/issues/detail?id=1263679

Brave: 1.34.80 Chromium: 97.0.4692.71 (Official Build) (64-bit)
Revision: adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS: Windows 10 Version 21H1 (Build 19043.1466)

@kjozwiak kjozwiak added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix bug feature/search labels Jan 18, 2022
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 19, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 29, 2022

Closing as invalid. Brave has always allowed users to remove or delete search engines from the default list. In the screenshot you showed, you have to chose a different default search engine before deleting the entry. Otherwise, we would need to guess what search engine you would want instead.

The chromium bug cited was never fixed and looks like the solution in the bug is going to turn into a confirmation dialog versus disabling deleting of search engines in the defaulted list.

@rebron rebron closed this as completed Jun 29, 2022
@rebron rebron added closed/invalid and removed bug priority/P5 Not scheduled. Don't anticipate work on this any time soon. feature/search Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop labels Jun 29, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 29, 2022

@manikandancode Thanks for filing. It was good to see how they were thinking about fixing https://bugs.chromium.org/p/chromium/issues/detail?id=1263679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants