Brave Ads dislike icon should be shown based upon the advertiser ID

[tmancey]

Description

Brave Ads dislike icon should be shown based upon the advertiser ID

Steps to Reproduce

1. View an ad
2. Dislike the ad (30-day Ads History)
3. View an ad (from the same category as the first ad but a different advertiser)
4. Navigate to the 30-day Ads History

Actual result:

Both ads show the dislike icon

Expected result:

Only the first ad should show the dislike icon

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

This is only a visual issue and does not affect frequency caps

[stephendonner]

Verified PASSED using

Brave	1.36.46 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	macOS Version 11.6.1 (Build 20G224)

Steps:

1. new profile
2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
3. opened brave://rewards
4. clicked on Start using Rewards
5. opened a few tabs
6. waited for the 1st ad
7. received 1st ad
8. loaded brave://rewards
9. clicked on 30-day Ads History
10. clicked on the thumbs-down (downvote) icon beneath the Viewed column, for the 1st ad
11. waited for the 2nd ad
12. received 2nd ad
13. loaded brave://rewards
14. clicked on 30-day Ads History
15. looked at the 2nd ad's state

Confirmed the 2nd ad did not also have a thumbs-down vote

example	example

Logs:

1st ad (down-voted)

[30020:259:0119/100802.916619:VERBOSE1:ad_notification_serving.cc(260)] Serving ad notification:
  uuid: 0d5f6316-6793-402e-b9ac-736ec271b579
  creativeInstanceId: 2b70bdb0-69b8-450c-b3fe-db69b631258c
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad Set 1 - Creative 1 - Ad 1
  body: Ad Set 1 - Creative 1 - Ad 1
  targetUrl: https://youtube.com

[30020:259:0119/100812.238957:VERBOSE1:confirmations.cc(284)] Successfully redeemed unblinded token for ad_notification with confirmation id 4db19303-642a-4246-ac3e-7079f6dba274, transaction id b0a063b9-83e9-4735-8705-295f409f76cd, creative instance id 2b70bdb0-69b8-450c-b3fe-db69b631258c and view. You now have 1 unblinded payment tokens which will be redeemed in 0 hours, 8 minutes, 8 seconds at 10:16 AM
[30020:259:0119/100822.909024:VERBOSE1:confirmations.cc(69)] Confirming downvote for ad_notification with transaction id 299eaf8f-c064-4650-ac40-d8b4a27a29bb and creative instance id 2b70bdb0-69b8-450c-b3fe-db69b631258c

2nd ad

[30020:259:0119/100845.386381:VERBOSE1:confirmations.cc(213)] Added dismiss confirmation for ad_notification with id a48e1e8c-6898-4ca8-8318-cdbcad7a682d, transaction idcad7e82b-de4c-43cc-a2f6-ce2cab385334 and creative instance id 2b70bdb0-69b8-450c-b3fe-db69b631258c to the confirmations queue
[30020:259:0119/100852.435442:VERBOSE1:confirmations.cc(284)] Successfully redeemed unblinded token for ad_notification with confirmation id a48e1e8c-6898-4ca8-8318-cdbcad7a682d, transaction id cad7e82b-de4c-43cc-a2f6-ce2cab385334, creative instance id 2b70bdb0-69b8-450c-b3fe-db69b631258c and dismiss. You now have 3 unblinded payment tokens which will be redeemed in 0 hours, 7 minutes, 27 seconds at 10:16 AM

[30020:259:0119/101421.330902:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[30020:259:0119/101421.332017:VERBOSE1:eligible_ad_notifications_v1.cc(80)] Get eligible ads for parent-child segments:
[30020:259:0119/101421.332072:VERBOSE1:eligible_ad_notifications_v1.cc(82)]   gaming-gaming
[30020:259:0119/101421.332111:VERBOSE1:eligible_ad_notifications_v1.cc(82)]   hobbies & interests-genealogy
[30020:259:0119/101421.332147:VERBOSE1:eligible_ad_notifications_v1.cc(82)]   education-education
[30020:259:0119/101421.332767:VERBOSE1:eligible_ad_notifications_v1.cc(98)] No eligible ads for parent-child segments
[30020:259:0119/101421.332835:VERBOSE1:eligible_ad_notifications_v1.cc(119)] Get eligible ads for parent segments:
[30020:259:0119/101421.332893:VERBOSE1:eligible_ad_notifications_v1.cc(121)]   gaming
[30020:259:0119/101421.332976:VERBOSE1:eligible_ad_notifications_v1.cc(121)]   hobbies & interests
[30020:259:0119/101421.333020:VERBOSE1:eligible_ad_notifications_v1.cc(121)]   education
[30020:259:0119/101421.333597:VERBOSE1:eligible_ad_notifications_v1.cc(137)] No eligible ads for parent segments
[30020:259:0119/101421.333645:VERBOSE1:eligible_ad_notifications_v1.cc(150)] Get eligible ads for untargeted segment

Confirmed the 1st ad's advertiserId and creativeSetId were excluded:

[30020:259:0119/101421.336944:VERBOSE2:exclusion_rules_base.cc(123)] advertiserId ecbcc833-8b1d-4867-98f7-ad2341396ce8 excluded due to being disliked
[30020:259:0119/101421.339968:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId f8984c50-ca1f-450a-94c7-d582b4101253 excluded as not within the targeted subdivision

[30020:259:0119/101421.341305:VERBOSE2:ad_priority.h(32)] 11 ads with a priority of 1 in bucket 1
[30020:259:0119/101421.341902:VERBOSE1:ad_notification_serving.cc(141)] Found 11 eligible ads
[30020:259:0119/101421.341953:VERBOSE1:ad_notification_serving.cc(260)] Serving ad notification:
  uuid: b9a2b08c-dc04-4618-9059-7f63e5e5126a
  creativeInstanceId: 97fbbf00-0312-436f-a751-88d757a79b7b
  creativeSetId: c5869bfb-7b3e-45e9-83c8-66ec3ac2b937
  campaignId: 12e88c0d-fb1b-4316-ade0-cc06eb57227e
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Verifiable Ad Conversion - DOM
  body: VAC - Get VAC ID from DOM
  targetUrl: https://brave.com?testCase=VAC-DOM
[30020:259:0119/101421.342395:VERBOSE1:ads_service_impl.cc(1912)] Timeout ad notification with uuid b9a2b08c-dc04-4618-9059-7f63e5e5126a in 120 seconds
[30020:259:0119/101421.342453:VERBOSE3:ad_notification_event_served.cc(24)] Served ad notification with uuid b9a2b08c-dc04-4618-9059-7f63e5e5126a and creative instance id 97fbbf00-0312-436f-a751-88d757a79b7b
[30020:259:0119/101421.342644:VERBOSE1:ad_notification_serving.cc(153)] Served ad notification
[30020:259:0119/101421.342691:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid b9a2b08c-dc04-4618-9059-7f63e5e5126a and creative instance id 97fbbf00-0312-436f-a751-88d757a79b7b
[30020:259:0119/101421.358106:VERBOSE1:ad_notification_event_served.cc(32)] Successfully logged ad notification served event
[30020:259:0119/101421.369634:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[30020:259:0119/101421.378010:VERBOSE3:ads_impl.cc(762)] Successfully deposited funds for ad_notification with creative instance id 97fbbf00-0312-436f-a751-88d757a79b7b and view valued at 0.01
[30020:259:0119/101421.378100:VERBOSE1:confirmations.cc(69)] Confirming view for ad_notification with transaction id 99d04a40-0d54-4251-a922-d69712a0cc75 and creative instance id 97fbbf00-0312-436f-a751-88d757a79b7b

[30020:259:0119/101426.764335:VERBOSE1:confirmations.cc(284)] Successfully redeemed unblinded token for ad_notification with confirmation id c58497f0-3ca9-42d6-8ac7-3586a6fb4521, transaction id 99d04a40-0d54-4251-a922-d69712a0cc75, creative instance id 97fbbf00-0312-436f-a751-88d757a79b7b and view. You now have 4 unblinded payment tokens which will be redeemed in 0 hours, 1 minute, 53 seconds at 10:16 AM