Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to connected site list in the panel #20380

Closed
bbondy opened this issue Jan 7, 2022 · 1 comment · Fixed by brave/brave-core#11797
Closed

Link to connected site list in the panel #20380

bbondy opened this issue Jan 7, 2022 · 1 comment · Fixed by brave/brave-core#11797
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 7, 2022

Users sometimes have trouble finding this link:
brave://settings/content/ethereum?search=ethereum

We should link from it in the menu on the panel and possibly also the one in brave://wallet

cc @Douglashdaniel
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 7, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 7, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 9, 2022
@Douglashdaniel Douglashdaniel added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 9, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 10, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 10, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Brave 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11797
  • Verified connected sites option is available in Panel and on portfolio menu
  • Verified connected sites option is only shown on webpages and not on internal pages
  • Verified for a non-connected site panel shows Connect instead of Disconnected
  • Encountered #20973 & #20974
20380-Linux.mp4
20380-Windows.mov
20380-macOS.mov

@Douglashdaniel Douglashdaniel mentioned this issue Feb 15, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Connected Sites Button in More Menu brave/brave-core
3 participants
@bbondy @srirambv @Douglashdaniel