Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dapp webcompat issue with https://studio.manifold.xyz/ #20283

Closed
bbondy opened this issue Jan 1, 2022 · 1 comment · Fixed by brave/brave-core#11720
Closed

Fix Dapp webcompat issue with https://studio.manifold.xyz/ #20283

bbondy opened this issue Jan 1, 2022 · 1 comment · Fixed by brave/brave-core#11720
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.34.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 1, 2022 •
edited
Loading

personal_sign should accept hex message without 0x prefix too.

After signing in on the Dapp https://studio.manifold.xyz/ it tries to sign data with personal sign without 0x prefix for the hex data.

See the implementation of personal_sign here:
https://github.com/ethereum/go-ethereum/pull/2940/files#diff-d0d5842eca210323f32aeb8c0710124e1bfd1a19f732c7ed5ee7519a318a405aR40

QA test plan

  1. Navigate to https://studio.manifold.xyz/
  2. Click to connect wallet, give permissions and then also sign the data.
  3. It should continue to the next step and not go back to the connect screen.
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 1, 2022
@bbondy bbondy self-assigned this Jan 1, 2022
@bbondy bbondy mentioned this issue Jan 1, 2022
Merged
25 tasks
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 2, 2022
This was referenced Jan 2, 2022
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented Jan 4, 2022

Brave 1.34.78 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from issue description
  • Verified connect wallet continues and connects successfully without going back
20283.-.Linux.mp4
20283.-.Win.mov
20283.-.mac.mov

@bbondy bbondy changed the title personal_sign should accept hex message without 0x prefix too Fix Dapp webcompat issue with https://studio.manifold.xyz/ Jan 4, 2022
@LaurenWags LaurenWags mentioned this issue Jan 4, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Make signing methods more compatible with MetaMask brave/brave-core
3 participants
@bbondy @kjozwiak @srirambv