Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support image param in wallet_watchAsset #20000

Closed
yrliou opened this issue Dec 9, 2021 · 1 comment · Fixed by brave/brave-core#12003
Closed

Support image param in wallet_watchAsset #20000

yrliou opened this issue Dec 9, 2021 · 1 comment · Fixed by brave/brave-core#12003
Assignees

Comments

@yrliou
Copy link
Member

yrliou commented Dec 9, 2021

Currently we do not support providing the image URL for custom tokens via wallet_watchAsset because we don't support getting a remote resource yet.

Test Plan:

  1. Visit https://www.coingecko.com/en/coins/railgun and click on the fox icon to add suggest token

add_to_metamask

  1. Prompt should show up for adding suggest token (will be asking to unlock first if wallet is locked), make sure the icon is displayed as expected here.
    Screen Shot 2022-01-26 at 2 02 41 PM

  2. Click to add the token and check the token is added to user visible asset list and make sure the icon is displayed as expected here.
    Screen Shot 2022-01-26 at 2 03 08 PM

@srirambv
Copy link
Contributor

Brave 1.36.90 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified test plan from issue description
  • Verified Add token shows icon for the coin that is being added
  • Verified custom asset added shows the icon on visible asset list
20000-Linux.mp4
20000-Windows.mov
20000-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants