Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons are wrong color in Rewards flyout panel #19907

Closed
stephendonner opened this issue Dec 3, 2021 · 2 comments · Fixed by brave/brave-core#10664
Closed

Buttons are wrong color in Rewards flyout panel #19907

stephendonner opened this issue Dec 3, 2021 · 2 comments · Fixed by brave/brave-core#10664
Assignees
@samartnik
Labels
bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.34.x - Release

Comments

@stephendonner
Copy link

Description

Buttons are wrong color in Rewards flyout panel

Steps to reproduce

  1. install 1.35.3
  2. upgrade to the PR build, which is 1.35.5 with CR97
  3. open laurenwags.github.io and tap on the BAT icon
  4. look at the resulting Rewards panel

Actual result

Screenshot_20211203-101718

Expected result

Screenshot_20211203-101517

Issue reproduces how often

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL (phone)
  • Android version: 9.0

Brave version

Brave - Nightly 1.35.5, Chromium 97.0.4692.36`

cc @samartnik @mkarolin @kjozwiak @srirambv
@stephendonner stephendonner added bug regression OS/Android Fixes related to Android browser functionality labels Dec 3, 2021
@stephendonner stephendonner mentioned this issue Dec 3, 2021
Closed
23 tasks
@samartnik samartnik self-assigned this Dec 3, 2021
@samartnik samartnik added this to the 1.35.x - Nightly milestone Dec 3, 2021
@samartnik
Copy link
Contributor

Fixed directly in cr97 branch brave/brave-core@92f4e2b

@mkarolin mkarolin mentioned this issue Dec 3, 2021
Merged
24 tasks
@mkarolin mkarolin mentioned this issue Dec 14, 2021
Merged
25 tasks
@stephendonner
Copy link
Author

stephendonner commented Dec 20, 2021 •
edited by btlechowski
Loading

Verified PASSED using Brave 1.34.67, Chromium 97.0.4692.56 with the original inline testplan.

Confirmed button colors have returned to normal.

Screenshot_20211220-111716

Verification passed on Brave v1.34.73 on Samsung Galaxy Tab S5e (Android 10.0)

Screenshot_20211225-001413_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 96 to Chromium 97 brave/brave-core
4 participants
@stephendonner @kjozwiak @samartnik @btlechowski