Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifications for successful / failed transactions #19885

Closed
bbondy opened this issue Dec 3, 2021 · 2 comments · Fixed by brave/brave-core#13330
Closed

Add notifications for successful / failed transactions #19885

bbondy opened this issue Dec 3, 2021 · 2 comments · Fixed by brave/brave-core#13330
Assignees
@spylogsster
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Dec 3, 2021

Currently when a transaction fails or succeeds, the user needs to go find the transaction.
We should have a notification and if you click it, it should go to the transaction list with that item in view.
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 3, 2021
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 3, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 21, 2021
@spylogsster spylogsster self-assigned this May 10, 2022
@spylogsster spylogsster mentioned this issue May 13, 2022
Merged
25 tasks
@spylogsster spylogsster added this to the 1.41.x - Nightly milestone May 20, 2022
@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2022

Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13330
  • Verified a transaction notification is shown for both successful and error'd transaction
  • Verified a transaction notification is only shown when system notification is enabled
  • Verified a transaction notification is not shown if Focus assist is enabled on Windows
  • Verified a transaction notification is not shown if the system is set to DnD
19885-Linux.mp4
19885-Windows.mp4
19885-macOS.mov

This was referenced Jul 1, 2022
Closed
Open
Open
@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Removing Android label as Android specific issue is logged #23879

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jul 5, 2022
@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Added notifications for Confirmed, Error and Dropped status changes brave/brave-core
3 participants
@bbondy @spylogsster @srirambv