Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when Etherscan EIP-1559 gas oracle is down #19869

Open
onyb opened this issue Dec 2, 2021 · 2 comments
Open

Handle case when Etherscan EIP-1559 gas oracle is down #19869

onyb opened this issue Dec 2, 2021 · 2 comments
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Required QA/Yes release-notes/include

Comments

@onyb
Copy link
Member

onyb commented Dec 2, 2021

Do not prevent transaction creation when Etherscan's EIP-1559 gas oracle is down. Currently in such an event, we prevent creation of the unapproved transaction with the following error in the console:

Sending unapproved transaction failed: from=0xa92... err=Failed to get the gas fees for EIP-1559 transaction

There are several ways of addressing this. Here are some ideas:

  • create a legacy Type-0 transaction instead.
  • populate some sane defaults for maxPriorityFeePerGas and maxFeePerGas and hope there's enough room to burn the necessary base fee.
@aman-m1
Copy link

aman-m1 commented Mar 30, 2023

@onyb Any uodate here. I'm facing similar issue on zkSync Testnet and Mainnet- https://community.brave.com/t/swap-on-zksync-testnet-through-a-dapp-does-not-initiate/477412

@MicahZoltu
Copy link

An oracle isn't needed at all. Just set the maxFeePerGas to latestBlock.baseFee * 2 + 100000000 and set the maxPriorityFee to 100000000 (100000000 == 0.1 nanoeth).

That strategy should be used broadly, I don't know why you query an oracle at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Required QA/Yes release-notes/include
Projects
Status: Backlog
Development

No branches or pull requests

4 participants