Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet URLs that redirect to the lock screen should go back to the correct URL after unlocking #19820

Closed
bbondy opened this issue Nov 30, 2021 · 1 comment · Fixed by brave/brave-core#12135
Closed

Wallet URLs that redirect to the lock screen should go back to the correct URL after unlocking #19820

bbondy opened this issue Nov 30, 2021 · 1 comment · Fixed by brave/brave-core#12135
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 30, 2021

If you type this:
brave://wallet/crypto/accounts

and your wallet is locked, it goes to the unlock URL.

But after you unlock it doesn't go to brave://wallet/crypto/accounts

This makes it a bit harder for people to understand steps when answering in support.

cc @Douglashdaniel
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 30, 2021
@srirambv srirambv mentioned this issue Dec 4, 2021
Closed
@Douglashdaniel Douglashdaniel self-assigned this Feb 3, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 3, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 4, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 16, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 11 Version 21H2 (Build 22000.556)

Verified using the STR/Cases outlined via brave/brave-core#12135 (comment).

About.Version.-.Brave.2022-03-25.03-25-19.mp4

@bbondy bbondy removed the OS/Android Fixes related to Android browser functionality label Mar 25, 2022
@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Redirect to Session Route After Unlock brave/brave-core
4 participants
@bbondy @kjozwiak @LaurenWags @Douglashdaniel