Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet swap: set the focus in the coin search field #19788

Closed
tredondo opened this issue Nov 28, 2021 · 4 comments · Fixed by brave/brave-core#11923
Closed

Wallet swap: set the focus in the coin search field #19788

tredondo opened this issue Nov 28, 2021 · 4 comments · Fixed by brave/brave-core#11923
Assignees
@muliswilliam
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes good first issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@tredondo
Copy link

Description

In the wallet, swap dialog, after clicking the input or output currency, the "Select from" combo box should set the focus in the "Search coins" field.

Steps to Reproduce

  1. Go to brave://wallet/crypto/portfolio/ETH
  2. Click Swap
  3. Click "ETH" or "BAT"

image

Brave version (brave://version info)

Brave 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Version/Channel Information:

Version 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
@srirambv srirambv added enhancement feature/web3/wallet Integrating Ethereum+ wallet support good first issue labels Nov 29, 2021
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 4, 2021
@not-so-rabh
Copy link

Is it okay if I take up this?

@muliswilliam muliswilliam self-assigned this Jan 10, 2022
@evanrittenhouse
Copy link

@muliswilliam can I take this one? Saw that you self-assigned, but happy to take it up if you're busy.

@muliswilliam
Copy link

muliswilliam commented Jan 19, 2022 •
edited
Loading

@evanrittenhouse Go ahead

@muliswilliam muliswilliam added this to the 1.36.x - Nightly milestone Jan 20, 2022
@muliswilliam muliswilliam mentioned this issue Jan 20, 2022
Merged
25 tasks
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Mar 2, 2022

Brave 1.36.108 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11923
  • Verified selecting Swap tab on widget automatically sets focus on the input field of From token
  • Verified selecting the token name sets focus on the search coin list
  • Verified selecting token from the Swap tab on panel also sets focus on the coin search field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes good first issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Wallet swap: set the focus in the coin search field brave/brave-core
6 participants
@bbondy @tredondo @srirambv @not-so-rabh @muliswilliam @evanrittenhouse