Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: "Allow this app to spend your ?" [what?] #19785

Closed
tredondo opened this issue Nov 28, 2021 · 5 comments · Fixed by brave/brave-core#11736
Closed

Wallet: "Allow this app to spend your ?" [what?] #19785

tredondo opened this issue Nov 28, 2021 · 5 comments · Fixed by brave/brave-core#11736
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@tredondo
Copy link

Description

Tried to use dYdX. After connecting, you must Enable USDC. That transaction generates a prompt that seems to be missing the currency name.

Steps to Reproduce

  1. Go to https://trade.dydx.exchange/trade/BTC-USD
  2. Connect Brave's wallet
  3. Click "Deposit" then "Enable USDC"

Actual result:

image

Brave version (brave://version info)

Brave 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Version/Channel Information:

Version 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)

@srirambv srirambv added bug feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes labels Nov 29, 2021
@srirambv
Copy link
Contributor

srirambv commented Nov 29, 2021

I've seen this before as well but assumed it was a user error. Had discussed with @Douglashdaniel as well regarding this

@Douglashdaniel
Copy link

Douglashdaniel commented Nov 29, 2021

This issue happens when the token that you are allowing to spend is not set as a visible asset in your portfolio.

If the token that you are allowing to spend is not set as one of your visible tokens we do not have a record of it being one of your assets nor do we know how much of that asset you own that you can allow to be spent.

Will likely need to be resolved by a backend API to allow us to get that information from Etherscan, etc... first before front end can resolve this issue.

@Douglashdaniel
Copy link

Looks like the API needed is in the works #19279 🙂

@bbondy
Copy link
Member

bbondy commented Nov 30, 2021

@Douglashdaniel if the info is in our token registry and not a visible asset I think this can be supported.

@srirambv
Copy link
Contributor

Brave 1.36.90 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11736
  • Verified panel correctly shows the token name in Allow spend screen
  • Verified allow spend shows the token name correctly whether it is listed in visible assets or not
19785-Linux.mp4
19785-Windows.mov
19785-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants