Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a custom RPC URL should remove input field #19782

Closed
tredondo opened this issue Nov 27, 2021 · 2 comments · Fixed by brave/brave-core#11338
Closed

Deleting a custom RPC URL should remove input field #19782

tredondo opened this issue Nov 27, 2021 · 2 comments · Fixed by brave/brave-core#11338
Assignees
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@tredondo
Copy link

Description

At brave://settings/wallet/networks, add a new network (see #19781), then double click it

Steps to Reproduce

  1. brave://settings/wallet/networks
  2. Add a new network, e.g. BSC
  3. Make sure to add all three RPC URLs
  4. Click "Submit"
  5. Double-click the network
  6. Delete the last 2 RPC URLs.
  7. Try to Submit

Actual result:

image

Expected result:

Delete the URLs either with a UX affordance, or by not erroring out if the user has cleared those fields.

Reproduces how often:

Every time

Brave version (brave://version info)

Brave 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Version/Channel Information:

Version 1.32.113 Chromium: 96.0.4664.45 (Official Build) (64-bit)

Miscellaneous Information:

Adding the BSC mainnet from these settings resulted in a ridiculous BNB balance (trillions).

@srirambv srirambv changed the title Impossible to remove RPC URL from "Add new network" RPC URLs Deleting a custom RPC URL should remove input field Nov 29, 2021
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 30, 2021
@spylogsster spylogsster self-assigned this Nov 30, 2021
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 30, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 20, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Dec 20, 2021

Verification in progress with

Brave | 1.34.67 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | macOS Version 11.6.1 (Build 20G224)

Reproduced the issue using 1.33.106 and STR:

1 33 106

Verified able to remove RPC URLs as per the STR.
Confirmed for both clean and upgraded profiles.

Step 2 Step 7 Success
1 34 x 1 1 34 x 2 1 34 x 3

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 20, 2021
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2022

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified deleting a custom RPC URL shows Invalid Address for the input field but still allows to click on Submit button
  • Verified deleting RPC URL and clicking on Submit shows confirmation of updating the custom network
  • Verified selecting Ok updates the list and removes the URL and updates the network details
Removed URL Delete Confirmation Updated Network details
image image image

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Linux
  • Verified deleting a custom RPC URL shows Invalid Address for the input field but still allows to click on Submit button
  • Verified deleting RPC URL and clicking on Submit shows confirmation of updating the custom network
  • Verified selecting Ok updates the list and removes the URL and updates the network details
Removed URL Delete Confirmation Updated Network details
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants