Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select network drop down should have a + icon that points to settings for network management #19763

Closed
bbondy opened this issue Nov 26, 2021 · 2 comments · Fixed by brave/brave-core#11470
Closed

Select network drop down should have a + icon that points to settings for network management #19763

bbondy opened this issue Nov 26, 2021 · 2 comments · Fixed by brave/brave-core#11470
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 26, 2021

Currently a user has no indication that a network can be added to brave://settings/wallet/networks
We should have a + button similar to how we have one for accounts.
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 26, 2021
@Miyayes
Copy link
Collaborator

Miyayes commented Dec 2, 2021

+1 https://www.reddit.com/r/BATProject/comments/r6s7sf/comment/hmv2ib6/

@muliswilliam muliswilliam self-assigned this Dec 3, 2021
@muliswilliam muliswilliam mentioned this issue Dec 7, 2021
Merged
24 tasks
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 9, 2021
@srirambv
Copy link
Contributor

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11470
  • Verified add network button is shown on network dropdown list on both widget and panel
  • Verified clicking on the + button loads a new tab and loads brave://settings/wallet/networks
Buy Tab on Widget
Send Tab on Widget
Swap Tab on Widget
Wallet Panel

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
4 participants
@bbondy @Miyayes @srirambv @muliswilliam