Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto detect token balances when > 0 balance #19746

Closed
bbondy opened this issue Nov 25, 2021 · 2 comments · Fixed by brave/brave-core#13295
Closed

Auto detect token balances when > 0 balance #19746

bbondy opened this issue Nov 25, 2021 · 2 comments · Fixed by brave/brave-core#13295
Assignees
@nvonpentz
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 25, 2021

It would be best for UX if we can auto detect a user's token balances and auto-add any token that has a balance, instead of making the user add them manually.

We may want to filter out some small balances if there's a lot of noise. This is only for tokens in our registry for now.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 25, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 26, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 26, 2021
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@nvonpentz nvonpentz moved this from Backlog to In Progress in Web3 May 9, 2022
@nvonpentz nvonpentz mentioned this issue May 11, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 Sep 26, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 26, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.46.70 x64 Beta build

  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

Verification passed on Samsung Tab A with Android 10 running 1.46.70 x64 Beta build

  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified restoring account via hardware wallet restores all the tokens from the account that have balance
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified restoring account via hardware wallet restores all the tokens from the account that have balance
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 12.6 (Build 21G115)
  • Verified test plan from brave/brave-core#13295
  • Verified restoring a wallet via seed shows all tokens that have balance across all accounts
  • Verified restoring an account via private key also restores/shows all tokens from that account in addition to already visible tokens
  • Verified restoring account via hardware wallet restores all the tokens from the account that have balance
  • Verified on a clean wallet only Ethereum and BAT are listed as expected and no other tokens are listed

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Dec 5, 2022
Closed
@yrliou yrliou mentioned this issue Feb 23, 2023
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Asset discovery brave/brave-core
4 participants
@bbondy @nvonpentz @srirambv @brave-builds