Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Hide Brave Rewards button" stands out from the other toggles #19695

Closed
fmarier opened this issue Nov 23, 2021 · 6 comments · Fixed by brave/brave-core#11810
Closed

"Hide Brave Rewards button" stands out from the other toggles #19695

fmarier opened this issue Nov 23, 2021 · 6 comments · Fixed by brave/brave-core#11810
Assignees
@emerick
Labels
feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Nov 23, 2021

The "Hide Brave Rewards button" toggle in brave://settings/appearance stands out from the rest of the toggles because all of the other ones use "Show xxxx" or "Always show xxxx":
Screenshot from 2021-11-23 14-22-25

We should change that to be "Show Brave Rewards button" (default ON) to match the rest of the settings. Otherwise some people may think we're trying to confuse people with a "dark pattern", as opposed to the real reason which is that we didn't notice the inconsistency when we originally added that toggle.

(Originally reported in https://neilzone.co.uk/2021/11/brave-browser-less-privacy-respectful-than-i-was-expecting by @neilzone.)
@Miyayes Miyayes added feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings labels Nov 23, 2021
@zenparsing zenparsing added priority/P4 Planned work. We expect to get to it "soon". design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Dec 1, 2021
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 3, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 3, 2022 •
edited
Loading

Simple proposal: The setting should read as follows:

Show Brave Rewards icon in URL bar

It should be enabled by default (toggled on). When user toggles off, then it will hide the Brave Rewards (BAT) icon.

@neilzone
Copy link

neilzone commented Jan 4, 2022

👍

@Miyayes Miyayes removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jan 5, 2022
@emerick emerick mentioned this issue Jan 11, 2022
Merged
25 tasks
@emerick emerick added this to the 1.36.x - Nightly milestone Jan 13, 2022
@stephendonner
Copy link

stephendonner commented Jan 14, 2022 •
edited
Loading

Verified PASSED using

Brave 1.36.39 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 10 Version 20H2 (Build 19042.1466)
Case 1: 1.34.80 upgrade, default pref - PASSED
  1. launch 1.34.80
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF (default)
  4. confirm Brave Rewards button is shown in the URL bar
  5. install 1.36.39 (upgrade)
  6. launch 1.36.39
  7. confirm Show Brave Rewards icon in address bar is set to ON
  8. confirm Brave Rewards button is shown in the URL bar
steps 3-4 steps 7-8
case-1-1 case-1-2
Case 2: 1.34.80 upgrade, toggled `ON` (hide) - PASSED
  1. launch 1.34.80
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF (default)
  4. toggle Hide Brave Rewards button to ON
  5. confirm there's NO Brave Rewards button is shown in the URL bar
  6. install 1.36.39 (upgrade)
  7. confirm Show Brave Rewards icon in address bar is set to OFF
  8. confirm there's NO Brave Rewards button in the URL bar
step 3 step 5 steps 7-8
case-2-1 case-2-2 case-2-3
Case 3: 1.36.39 fresh install, default pref - PASSED
  1. launch 1.36.39
  2. load brave://settings/appearance
  3. confirm Show Brave Rewards icon in address bar is set to ON
  4. confirm the Brave Rewards button is shown in the URL bar

steps 3-4

case-3-1

Case 4: 1.36.39, fresh install, toggled `OFF` - PASSED
  1. launch 1.36.39
  2. load brave://settings/appearance
  3. confirm Show Brave Rewards icon in address bar is set to ON
  4. confirm Brave Rewards button is shown in the URL bar
  5. toggle Show Brave Rewards icon in address bar to OFF
  6. confirm there's NO Brave Rewards button in the URL bar
steps 3-4 step 6
case-4-1 case-4-2
Case 5: 1.33.106 upgrade, default pref - PASSED
  1. launch 1.33.106
  2. confirm Hide Brave Rewards button set to OFF (default)
  3. confirm Brave Rewards button is shown in the URL bar
  4. install 1.36.39 latest (upgrade)
  5. launch 1.36.39
  6. confirm Show Brave Rewards icon in address bar is set to ON
  7. confirm Brave Rewards button is shown in the URL bar
steps 2-3 steps 6-7
case-5-1 image
Case 6: 1.33.106 upgrade, toggled `ON` (hide) - PASSED
  1. launch 1.33.106
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF
  4. confirm Brave Rewards button is shown in the URL bar
  5. toggle Hide Brave Rewards button to ON
  6. confirm NO Brave Rewards button is shown in the URL bar
  7. install 1.36.39 (upgrade)
  8. launch 1.36.39
  9. confirm Show Brave Rewards icon in address bar is set to OFF
  10. confirm NO Brave Rewards button is shown in the URL bar
steps 3-4 step 6 steps 9-10
case-6-1 case-6-2 case-6-3

@emerick emerick added the OS/Android Fixes related to Android browser functionality label Jan 14, 2022
@stephendonner
Copy link

stephendonner commented Jan 19, 2022 •
edited
Loading

Verified PASSED using

Brave 1.36.45 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Linux
Case 1: 1.34.80 upgrade, default pref - PASSED
  1. launch 1.34.80
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF (default)
  4. confirm Brave Rewards button is shown in the URL bar
  5. install 1.36.45 (upgrade)
  6. launch 1.36.45
  7. confirm Show Brave Rewards icon in address bar is set to ON
  8. confirm Brave Rewards button is shown in the URL bar
steps 3-4 steps 7-8
Screen Shot 2022-01-18 at 5 05 48 PM Screen Shot 2022-01-18 at 5 08 09 PM
Case 2: 1.34.80 upgrade, toggled `ON` (hide) - PASSED
  1. launch 1.34.80
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF (default)
  4. toggle Hide Brave Rewards button to ON
  5. confirm there's NO Brave Rewards button is shown in the URL bar
  6. install 1.36.45 (upgrade)
  7. confirm Show Brave Rewards icon in address bar is set to OFF
  8. confirm there's NO Brave Rewards button in the URL bar
step 3 step 5 steps 7-8
Screen Shot 2022-01-18 at 5 14 13 PM Screen Shot 2022-01-18 at 5 14 32 PM Screen Shot 2022-01-18 at 5 15 23 PM
Case 3: 1.36.45 fresh install, default pref - PASSED
  1. launch 1.36.45
  2. load brave://settings/appearance
  3. confirm Show Brave Rewards icon in address bar is set to ON
  4. confirm the Brave Rewards button is shown in the URL bar

steps 3-4

Screen Shot 2022-01-18 at 5 18 20 PM
Case 4: 1.36.45, fresh install, toggled `OFF` - PASSED
  1. launch 1.36.45
  2. load brave://settings/appearance
  3. confirm Show Brave Rewards icon in address bar is set to ON
  4. confirm Brave Rewards button is shown in the URL bar
  5. toggle Show Brave Rewards icon in address bar to OFF
  6. confirm there's NO Brave Rewards button in the URL bar
steps 3-4 step 6
Screen Shot 2022-01-18 at 5 22 21 PM Screen Shot 2022-01-18 at 5 22 39 PM
Case 5: 1.33.106 upgrade, default pref - PASSED
  1. launch 1.33.106
  2. confirm Hide Brave Rewards button set to OFF (default)
  3. confirm Brave Rewards button is shown in the URL bar
  4. install 1.36.45 latest (upgrade)
  5. launch 1.36.45
  6. confirm Show Brave Rewards icon in address bar is set to ON
  7. confirm Brave Rewards button is shown in the URL bar
steps 2-3 steps 6-7
Screen Shot 2022-01-18 at 5 26 19 PM Screen Shot 2022-01-18 at 5 27 12 PM
Case 6: 1.33.106 upgrade, toggled `ON` (hide) - PASSED
  1. launch 1.33.106
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF
  4. confirm Brave Rewards button is shown in the URL bar
  5. toggle Hide Brave Rewards button to ON
  6. confirm NO Brave Rewards button is shown in the URL bar
  7. install 1.36.45 (upgrade)
  8. launch 1.36.39
  9. confirm Show Brave Rewards icon in address bar is set to OFF
  10. confirm NO Brave Rewards button is shown in the URL bar
steps 3-4 step 6 steps 9-10
Screen Shot 2022-01-18 at 5 30 17 PM Screen Shot 2022-01-18 at 5 30 40 PM Screen Shot 2022-01-18 at 5 31 12 PM

Verified PASSED using

Brave 1.36.46 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 12.2 (Build 21D5039d)
Case 1: 1.34.80 upgrade, default pref - PASSED
  1. launch 1.34.80
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF (default)
  4. confirm Brave Rewards button is shown in the URL bar
  5. install 1.36.46 (upgrade)
  6. launch 1.36.46
  7. confirm Show Brave Rewards icon in address bar is set to ON
  8. confirm Brave Rewards button is shown in the URL bar
steps 3-4 steps 7-8
Screen Shot 2022-01-18 at 6 28 47 PM Screen Shot 2022-01-18 at 6 29 34 PM
Case 2: 1.34.80 upgrade, toggled `ON` (hide) - PASSED
  1. launch 1.34.80
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF (default)
  4. toggle Hide Brave Rewards button to ON
  5. confirm there's NO Brave Rewards button is shown in the URL bar
  6. install 1.36.46 (upgrade)
  7. confirm Show Brave Rewards icon in address bar is set to OFF
  8. confirm there's NO Brave Rewards button in the URL bar
step 3 step 5 steps 7-8
Screen Shot 2022-01-18 at 6 36 55 PM Screen Shot 2022-01-18 at 6 37 03 PM Screen Shot 2022-01-18 at 6 37 56 PM
Case 3: 1.36.46 fresh install, default pref - PASSED
  1. launch 1.36.46
  2. load brave://settings/appearance
  3. confirm Show Brave Rewards icon in address bar is set to ON
  4. confirm the Brave Rewards button is shown in the URL bar

steps 3-4

Screen Shot 2022-01-18 at 6 53 15 PM
Case 4: 1.36.46, fresh install, toggled `OFF` - PASSED
  1. launch 1.36.46
  2. load brave://settings/appearance
  3. confirm Show Brave Rewards icon in address bar is set to ON
  4. confirm Brave Rewards button is shown in the URL bar
  5. toggle Show Brave Rewards icon in address bar to OFF
  6. confirm there's NO Brave Rewards button in the URL bar
steps 3-4 step 6
Screen Shot 2022-01-18 at 6 50 12 PM Screen Shot 2022-01-18 at 6 51 07 PM
Case 5: 1.33.106 upgrade, default pref - PASSED
  1. launch 1.33.106
  2. confirm Hide Brave Rewards button set to OFF (default)
  3. confirm Brave Rewards button is shown in the URL bar
  4. install 1.36.46 latest (upgrade)
  5. launch 1.36.46
  6. confirm Show Brave Rewards icon in address bar is set to ON
  7. confirm Brave Rewards button is shown in the URL bar
steps 2-3 steps 6-7
Screen Shot 2022-01-18 at 6 46 36 PM Screen Shot 2022-01-18 at 6 47 39 PM
Case 6: 1.33.106 upgrade, toggled `ON` (hide) - PASSED
  1. launch 1.33.106
  2. load brave://settings/appearance
  3. confirm Hide Brave Rewards button is set to OFF
  4. confirm Brave Rewards button is shown in the URL bar
  5. toggle Hide Brave Rewards button to ON
  6. confirm NO Brave Rewards button is shown in the URL bar
  7. install 1.36.46 (upgrade)
  8. launch 1.36.46
  9. confirm Show Brave Rewards icon in address bar is set to OFF
  10. confirm NO Brave Rewards button is shown in the URL bar
steps 3-4 step 6 steps 9-10
Screen Shot 2022-01-18 at 6 54 37 PM Screen Shot 2022-01-18 at 6 54 42 PM Screen Shot 2022-01-18 at 6 55 15 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 19, 2022
@Miyayes Miyayes mentioned this issue Jan 23, 2022
Closed
@kjozwiak
Copy link
Member

Adding QA/Blocked for Android till #21183 is addressed/fixed. The above can also be tested alongside #20633 & #20646 when #21183 is fixed.

@kjozwiak kjozwiak mentioned this issue Feb 18, 2022
Closed
@srirambv
Copy link
Contributor

Verification passed as part of #21183 (comment).

  • Verified on both clean install and upgrade scenario rewards button is hidden or shown based on the setting

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Migrate kHideButton preference to kShowButton preference brave/brave-core
9 participants
@fmarier @stephendonner @neilzone @kjozwiak @emerick @zenparsing @Miyayes @srirambv @minkyeongshin