Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFS interstitial page has styling issues in Dark mode #19469

Closed
stephendonner opened this issue Nov 16, 2021 · 2 comments · Fixed by brave/brave-core#11168
Closed

IPFS interstitial page has styling issues in Dark mode #19469

stephendonner opened this issue Nov 16, 2021 · 2 comments · Fixed by brave/brave-core#11168
Assignees
@spylogsster
Labels
feature/web3/ipfs OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.34.x - Release

Comments

@stephendonner
Copy link

Description

IPFS interstitial page has styling issues in Dark mode

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. switch to dark mode via brave://settings/appearance
  4. load ipns://ipfs.io

Actual result:

Screen Shot 2021-11-15 at 5 38 14 PM

Expected result:

Screen Shot 2021-11-15 at 5 38 11 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.34.15 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

/cc @spylogsster
@spylogsster spylogsster self-assigned this Nov 19, 2021
@spylogsster spylogsster mentioned this issue Nov 19, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 22, 2021
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.34.35 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

Screen Shot 2021-11-24 at 5 09 27 PM

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.34.62 Chromium: 96.0.4664.110 (Official Build) dev (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2 (Build 19042.1415)

ipfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Fix style for ipfs interstitial page brave/brave-core
2 participants
@stephendonner @spylogsster